fix: immediately invalidate session in all tabs on logout and documen… - #376
Merged
Lakes41 merged 2 commits intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a summary of the actions taken:
BroadcastChannel("guildpass:auth")) was already largely in place but failed to fully purge the local state inside
peer tabs. I updated the "signed-out" event listener in lib/wallet/providers.tsx so that when a logout is
initiated in one tab, all other open tabs immediately invoke the wagmi disconnect() method. This ensures that the
admin session is comprehensively invalidated and that UI guards revert seamlessly to the sign-in state in all
tabs.
behind sticking to sessionStorage alongside BroadcastChannel. The document explains the security tradeoffs
against localStorage (specifically the risk of lingering privileged sessions on shared computers versus
convenience).
The cross-tab synchronization works smoothly now, and you won't encounter stale authentications hanging around.
Let me know if you want to explore any further tweaks!
closes #256