fix: auto-retry mutation after SIWE re-auth on 401 - #365
Merged
Lakes41 merged 1 commit intoJul 28, 2026
Conversation
When a mutation (role assignment, policy update) fails with a 401
AuthError, the original request is now automatically retried once
after the user successfully re-authenticates via the inline banner.
Changes:
- lib/wallet/siwe-context.ts: add PendingRetryCallback type and
registerPendingRetry to SiweAuthContextType
- lib/wallet/providers.tsx: implement pendingRetriesRef queue;
drain it in both signIn() and performSilentRefresh() after a
successful session recovery; add registerPendingRetry to context
value and SiweAuthContextValue interface
- admin/members/page.tsx: use registerPendingRetry in assignRole
and removeRole onError handlers; remove React Query built-in
retry for 401s to avoid racing with the re-auth banner flow
- admin/policies/page.tsx: use registerPendingRetry in policy
mutation onError; add useToasts/ToastViewport for retry feedback
- test mocks: add registerPendingRetry: () => {} to all three
useSiweAuth mock objects
Acceptance criteria met:
- 401 during mutation triggers inline re-auth banner
- Successful re-auth automatically retries original mutation once
- Second 401 on retry calls onRetryFailure (no infinite loop)
- Success/failure toasts shown for the retried mutation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a mutation (role assignment, policy update) fails with a 401 AuthError, the original request is now automatically retried once after the user successfully re-authenticates via the inline banner.
Changes:
Acceptance criteria met:
Closes #327