Skip to content

fix: validate access override expiry - #312

Open
Tsammie wants to merge 1 commit into
Adamantine-guild:mainfrom
Tsammie:fix/access-override-expires-at-validation
Open

fix: validate access override expiry#312
Tsammie wants to merge 1 commit into
Adamantine-guild:mainfrom
Tsammie:fix/access-override-expires-at-validation

Conversation

@Tsammie

@Tsammie Tsammie commented Jul 28, 2026

Copy link
Copy Markdown

Summary

  • Added explicit expiresAt validation for createAccessOverride.
  • Rejected malformed expiry values with a clear 400 validation error instead of allowing raw database errors.
  • Made past-dated expiry behavior explicit by rejecting already-expired overrides.
  • Added focused tests for valid, malformed, omitted/null, and past-dated expiry inputs.

Notes

This PR keeps the change focused on access override expiry validation. It does not change the Prisma schema, migrations, or unrelated service behavior.

Checks

  • Malformed expiresAt values return a clear 400 error
  • Past-dated expiresAt behavior is explicit and tested
  • Valid future expiresAt values still work
  • Omitted/null expiresAt behavior is preserved
  • git diff --check

Closes #130

@Lakes41

Lakes41 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Do endeavour to pass workflow @Tsammie

@Lakes41

Lakes41 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This PR cannot be merged automatically because one or more workflow checks failed.

Please review the failed checks, push a fix, and wait for the workflows to pass.

After the checks pass and there are no merge conflicts, the automation can review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate expiresAt format/future-dated constraint in createAccessOverride

2 participants