Skip to content

Consolidate duplicated domain types into packages/integration-client - #319

Merged
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
bridgetthnkechi87-cloud:refactor/shared-domain-types
Jul 29, 2026
Merged

Consolidate duplicated domain types into packages/integration-client#319
Lakes41 merged 1 commit into
Adamantine-guild:mainfrom
bridgetthnkechi87-cloud:refactor/shared-domain-types

Conversation

@bridgetthnkechi87-cloud

Copy link
Copy Markdown
Contributor

Closes #291

Summary

  • Removed duplicate Pass, Guild, and Member interface definitions from apps/dashboard/lib/mock-data.ts
  • Reused the shared domain types exported by @guildpass/integration-client
  • Re-exported those types from mock-data.ts so existing dashboard imports continue working
  • Added README documentation for shared domain type exports
  • Fixed invalid ignoreDeprecations values in affected TypeScript configs so typecheck can run with the installed TypeScript version

Testing

  • pnpm --filter @guildpass/integration-client typecheck
  • pnpm --filter @guildpass/dashboard typecheck

Note

  • pnpm -r typecheck is currently blocked by an unrelated existing apps/access-api error: Cannot find module '@guildpass/contracts'.

@Lakes41
Lakes41 merged commit 7bc1e60 into Adamantine-guild:main Jul 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate duplicated domain types into packages/integration-client

2 participants