feat(dashboard): standardize guild and integration page states - #318
Merged
Lakes41 merged 1 commit intoJul 29, 2026
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardizes loading, error, and empty state handling across the
/guildsand/integrationsdashboard routes. Extracts sharedLoadingSkeleton,ErrorState, andEmptyStatecomponents (already partially present, now made reusable) so both routes follow the same visual and structural pattern already established in/dashboard,/passes,/members, and/activity.Linked Issue
Closes #255
Type of Change
Changes Made
apps/dashboard/components/LoadingSkeleton.tsx— new shared skeleton component, reused across/guildsand/integrationsapps/dashboard/components/ErrorState.tsx— new shared styled error componentapps/dashboard/components/EmptyState.tsx— extended with flexible props and responsive styling for reuse across routesapps/dashboard/components/GuildsListState.tsx/IntegrationsListState.tsx— route-specific adapters that wire the shared components into each page's data-fetching state, avoiding duplicated logicapps/dashboard/app/guilds/page.tsx— now renders loading/error/empty/unsupported states consistentlyapps/dashboard/app/integrations/page.tsx,app/integrations/loading.tsx,app/integrations/error.tsx— added loading/error boundaries and empty-state handlingapps/dashboard/test/list-page-states.test.ts— 6 new tests covering loading, error, and empty rendering for both routesapps/dashboard/README.md— documented the?mockState=error|emptysimulation mechanism for manual testingTest Evidence
Manual verification:
/guilds?mockState=errorand/integrations?mockState=errorrender the styled error state/guilds?mockState=emptyand/integrations?mockState=emptyrender the distinct empty stateChecklist
pnpm typecheckpasses with no errorspnpm lintpasses (or issues are pre-existing and documented)pnpm testpasses (all existing tests still pass)pnpm dev:docs.env.exampleScreenshots / Recordings
Additional Notes
This PR intentionally scopes only the changes required for #255. Unrelated dead-code cleanup and toolchain config fixes discovered during development (unused imports,
ignoreDeprecationsversion mismatch, an ESLint global) were kept out of this PR and will be submitted separately to keep this review focused.Additional Notes
This PR intentionally scopes only the changes required for #255. Unrelated dead-code cleanup and toolchain config fixes discovered during development (unused imports,
ignoreDeprecationsversion mismatch, an ESLint global) were kept out of this PR and will be submitted separately to keep this review focused.Note:
pnpm typecheckpasses cleanly for@guildpass/dashboard(the package touched in this PR). Running the full monorepo typecheck surfaces a pre-existing, unrelated error inapps/access-api/src/workers/indexer.ts(missing@guildpass/contractsmodule resolution) — confirmed present on the parent commit (71ead9a) as well, so it is not introduced by this change.