Skip to content

test(webhook-utils): add comprehensive signature edge cases #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lakes41 merged 1 commit into from
Jul 24, 2026
Merged

test(webhook-utils): add comprehensive signature edge cases #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 42 additions & 10 deletions packages/webhook-utils/test/verify.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,16 @@ describe("verifySignature", () => {
payload: PAYLOAD,
timestamp: futureTimestamp,
});
const result = verifySignature({
signatureHeader: signature,
secret: SECRET,
payload: PAYLOAD,
tolerance: 300,
});

assert.strictEqual(result.valid, false);
assert.ok(result.error.includes("future"));
});

test("should accept future timestamp within tolerance", () => {
const futureTimestamp = Math.floor(Date.now() / 1000) + 120;
Expand All @@ -189,16 +199,7 @@ describe("verifySignature", () => {
assert.strictEqual(result.valid, true);
assert.strictEqual(result.timestamp, futureTimestamp);
});
const result = verifySignature({
signatureHeader: signature,
secret: SECRET,
payload: PAYLOAD,
tolerance: 300,
});

assert.strictEqual(result.valid, false);
assert.ok(result.error.includes("future"));
});


test("should accept timestamp within tolerance", () => {
const recentTimestamp = Math.floor(Date.now() / 1000) - 200; // 200 seconds ago
Expand Down Expand Up @@ -311,6 +312,37 @@ describe("verifySignature", () => {
assert.strictEqual(result.valid, false);
assert.strictEqual(result.error, "Invalid signature");
});

test("should reject header containing only whitespace", () => {
const result = verifySignature({
signatureHeader: " ",
secret: SECRET,
payload: PAYLOAD,
});

assert.strictEqual(result.valid, false);
assert.strictEqual(result.error, "Invalid or missing timestamp in signature");
});

test("should reject header with trailing or leading malformed commas", () => {
const result = verifySignature({
signatureHeader: ",,,",
secret: SECRET,
payload: PAYLOAD,
});

assert.strictEqual(result.valid, false);
});

test("should reject header with float/decimal timestamp", () => {
const result = verifySignature({
signatureHeader: "t=12345.678,v1=abc123",
secret: SECRET,
payload: PAYLOAD,
});

assert.strictEqual(result.valid, false);
});
});

describe("Missing or invalid inputs", () => {
Expand Down