Skip to content

docs(lance-backend): scope no-cc claim to core-only; SDK rustls caveat (codex P2)#48

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/jirak-math-theorems-harvest-rfii13
Jun 19, 2026
Merged

docs(lance-backend): scope no-cc claim to core-only; SDK rustls caveat (codex P2)#48
AdaWorldAPI merged 1 commit into
mainfrom
claude/jirak-math-theorems-harvest-rfii13

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

Follow-up to #47 (merged), addressing the codex P2 review finding.

The lite-unified TL;DR command listed rustls and claimed "zero cc/C++ in the closure". That's wrong for the SDK build: surrealdb/Cargo.toml enables rustls with the aws_lc_rs crypto backend on non-WASM targets, and aws-lc-sys 0.41.0 depends on cc + cmake (verified Cargo.lock L884–893). So the documented "no-cc proof" command could still require native build tooling — misleading anyone verifying a no-native-toolchain Lance-only build.

Fix

  • The core-only command is now THE no-native-toolchain proof, and the "zero cc/C++" claim is scoped to it explicitly:
    cargo check -p surrealdb-core --no-default-features --features kv-lance
  • Added a ⚠ caveat section: the SDK --features kv-lance,rustls build does drop the C++ (kv-rocksdb) and gRPC (kv-tikv) storage engines, but is not cc-free because rustls's crypto backend pulls aws-lc-sys. To prove a no-cc SDK build, switch the TLS backend to ring (as the WASM target uses) or drop TLS.
  • Added a troubleshooting-matrix row for the cc/cmake-despite-no-kv-rocksdb symptom.

The storage-layer claim this card is about (drop RocksDB → no C++ storage dependency) was always correct; only the TLS-transport conflation needed fixing.

Notes

  • .claude/-only; no source or real Cargo.toml changes. Append-only AGENT_LOG.md entry added per the board convention.

🤖 Generated with Claude Code


Generated by Claude Code

Address codex P2: the lite-unified TL;DR command included `rustls`,
which on non-WASM enables the `aws_lc_rs` backend; `aws-lc-sys 0.41.0`
depends on `cc` + `cmake` (Cargo.lock L884-893). That contradicted the
"zero cc/C++ in the closure" claim for the SDK build.

- Make the core-only command (`cargo check -p surrealdb-core
  --no-default-features --features kv-lance`) THE no-native-toolchain
  proof; scope the "zero cc/C++" claim to it.
- Add a caveat section: the SDK `kv-lance,rustls` build drops the
  C++/gRPC storage engines but is NOT cc-free — rustls's crypto backend
  pulls aws-lc-sys. For a no-cc SDK, switch to the `ring` backend or
  drop TLS.
- Add a troubleshooting row for cc/cmake-despite-no-rocksdb.

The storage-layer claim (drop RocksDB → no C++ storage dependency) was
always correct; only the TLS-transport conflation needed fixing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi
@AdaWorldAPI AdaWorldAPI merged commit 173e99c into main Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 16 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6cda7033-cfaf-48bd-b25f-264e43431654

📥 Commits

Reviewing files that changed from the base of the PR and between 9e18040 and f860455.

📒 Files selected for processing (2)
  • .claude/board/AGENT_LOG.md
  • .claude/lance-backend/LANCE_FEATURE_GATES.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants