docs(lance-backend): scope no-cc claim to core-only; SDK rustls caveat (codex P2)#48
Conversation
Address codex P2: the lite-unified TL;DR command included `rustls`, which on non-WASM enables the `aws_lc_rs` backend; `aws-lc-sys 0.41.0` depends on `cc` + `cmake` (Cargo.lock L884-893). That contradicted the "zero cc/C++ in the closure" claim for the SDK build. - Make the core-only command (`cargo check -p surrealdb-core --no-default-features --features kv-lance`) THE no-native-toolchain proof; scope the "zero cc/C++" claim to it. - Add a caveat section: the SDK `kv-lance,rustls` build drops the C++/gRPC storage engines but is NOT cc-free — rustls's crypto backend pulls aws-lc-sys. For a no-cc SDK, switch to the `ring` backend or drop TLS. - Add a troubleshooting row for cc/cmake-despite-no-rocksdb. The storage-layer claim (drop RocksDB → no C++ storage dependency) was always correct; only the TLS-transport conflation needed fixing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcpLeEC3XK8Eye53GKBVvi
|
Warning Review limit reached
More reviews will be available in 41 minutes and 16 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Follow-up to #47 (merged), addressing the codex P2 review finding.
The lite-unified TL;DR command listed
rustlsand claimed "zero cc/C++ in the closure". That's wrong for the SDK build:surrealdb/Cargo.tomlenablesrustlswith theaws_lc_rscrypto backend on non-WASM targets, andaws-lc-sys 0.41.0depends oncc+cmake(verifiedCargo.lockL884–893). So the documented "no-cc proof" command could still require native build tooling — misleading anyone verifying a no-native-toolchain Lance-only build.Fix
--features kv-lance,rustlsbuild does drop the C++ (kv-rocksdb) and gRPC (kv-tikv) storage engines, but is not cc-free because rustls's crypto backend pullsaws-lc-sys. To prove a no-cc SDK build, switch the TLS backend toring(as the WASM target uses) or drop TLS.cc/cmake-despite-no-kv-rocksdbsymptom.The storage-layer claim this card is about (drop RocksDB → no C++ storage dependency) was always correct; only the TLS-transport conflation needed fixing.
Notes
.claude/-only; no source or realCargo.tomlchanges. Append-onlyAGENT_LOG.mdentry added per the board convention.🤖 Generated with Claude Code
Generated by Claude Code