Skip to content

deps(core): align kv-lance pins with lance-graph #423 (lance 4→6, lancedb 0.27→0.29, arrow 57→58) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaWorldAPI merged 1 commit into from
May 28, 2026
Merged

deps(core): align kv-lance pins with lance-graph #423 (lance 4→6, lancedb 0.27→0.29, arrow 57→58) #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions surrealdb/core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ surrealdb-types = { workspace = true }
vart.workspace = true

# External KV stores
lance = { version = "=4.0.0", optional = true }
lance-index = { version = "=4.0.0", optional = true }
lancedb = { version = "=0.27.2", optional = true }
arrow-array = { version = "57", optional = true }
arrow-schema = { version = "57", optional = true }
lance = { version = "=6.0.0", optional = true }
lance-index = { version = "=6.0.0", optional = true }
lancedb = { version = "=0.29.0", optional = true }
arrow-array = { version = "58", optional = true }
arrow-schema = { version = "58", optional = true }
Comment on lines +110 to +114

@chatgpt-codex-connector chatgpt-codex-connector Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Commit the lockfile updates for these pins

With Cargo.lock tracked, changing these exact dependency requirements without updating the lockfile leaves the workspace inconsistent: the lockfile still contains lance/lance-index 4.0.0, lancedb 0.27.2, and Arrow 57.3.1 entries. Any locked build or CI job that enables surrealdb-core/kv-lance will have to update the lockfile before it can resolve the new =6.0.0 / =0.29.0 requirements, so this change should include the corresponding Cargo.lock changes.

Useful? React with 👍 / 👎.

Comment on lines +110 to +114

@coderabbitai coderabbitai Bot May 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Update Cargo.lock alongside these pinned version bumps.

Lines 110-114 move the kv-lance dependency pins, but the provided lockfile context still resolves old versions (lance 4.0.0, lancedb 0.27.2, arrow-schema 57.3.1). Since CI runs with --locked, this can fail builds until lockfile entries are regenerated to match the new manifest pins.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@surrealdb/core/Cargo.toml` around lines 110 - 114, The Cargo.toml dependency
pins for lance, lance-index, lancedb, arrow-array and arrow-schema were changed
but Cargo.lock still resolves older versions; update the lockfile to match these
exact versions by running cargo update --precise for each package (e.g., cargo
update -p lance --precise 6.0.0, cargo update -p lance-index --precise 6.0.0,
cargo update -p lancedb --precise 0.29.0, cargo update -p arrow-array --precise
58, cargo update -p arrow-schema --precise 58) or run cargo generate-lockfile,
verify Cargo.lock now contains the pinned versions, and commit the updated
Cargo.lock alongside the Cargo.toml change so CI with --locked will succeed.

rocksdb = { workspace = true, optional = true }
tikv = { workspace = true, optional = true }

Expand Down