feat(rm-handlers): W8 — Query + IssueRelation (last standalone width track)#18
Merged
Merged
Conversation
…track) W8 of the Redmine Integration Plan — the saved-views & relations track. Completes the 8 Phase-1 width tracks. # Routes - GET /queries + /queries/:name (0x010D project_query) - GET /relations + /relations/:id (0x0111 project_relation) # URL keys - Query: name-slug URL (saved-view name doubles as label + slug), percent-encoded via common::encode_path_segment. - IssueRelation: record-key URL — relations have no natural slug (identified by their from/to endpoints + type), so they key on the SurrealDB record id like W1's Issue. # Scope vs canonical - Query: canonical class carries only `name` today; the filter / column / sort payload (Redmine's `filters`/`column_names`/ `sort_criteria`, mapped onto RenderColumn in REDMINE-QUERY-HARVEST.md) lands with D2 (filters depth track). For now a Query is a named saved view. - IssueRelation: row carries `relation_type` + `lag` (Redmine `delay` / OP `lag`, canonicalised to `lag`). Wiring the from/to record links to actual Issue rows lands when the Issue detail page embeds its relations (a W1-followup). # DoD pinned by 12 new tests Store (6): query round-trip-by-name / NotFound / list; relation round-trip / NotFound / list. Handlers (6): query list empty-state 0x010D + list/detail by name (percent-encoded `Open%20bugs`) + 404; relation list empty-state 0x0111 + list/detail by record key + 404. # Status: 8/8 standalone width tracks shipped W1 Issue, W2 Project, W3 TimeEntry, W4 User+Role, W5 Taxonomy(3/4), W6 News+WikiPage, W7 Repository+Changeset, W8 Query+IssueRelation. Remaining (not standalone list/detail pages): - nested sets: W4 Member/MemberRole/Watcher, W6 Comment/Message/ Forum/Attachment — embed under Project/Issue detail pages - W5 CustomField — ties to D1 (forms depth track) - depth tracks D1 (forms) / D2 (filters+sort+group) / D3 (RBAC) / D4 (workflows) / D5 (custom fields) / D6 (search) - GUI tracks G1 (layout chrome) / G2 (CSS) / G3 (JS) cargo fmt --check + cargo clippy --all-targets -- -D warnings + cargo test --workspace all green; 165 tests across 5 crates.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W8 — last standalone width track
Query (saved views) + IssueRelation (work-item dependency edges). Completes all 8 Phase-1 width tracks from the Integration Plan.
/queries[+/:name]0x010D project_query/relations[+/:id]0x0111 project_relationScope vs canonical
nametoday; the filter/column/sort payload (REDMINE-QUERY-HARVEST.md'sRenderColumnmapping) lands with D2 (filters depth track). A Query is a named saved view for now.relation_type+lag(Redminedelay/ OPlag, canonicalised). Bindingfrom/toto real Issue rows lands when the Issue detail page embeds its relations (W1-followup).DoD — 12 new tests; 165 across 5 crates
6 store + 6 handler (empty-state class_id, list+detail, 404 per resource; Query's name-slug percent-encoding pinned via
Open%20bugs). fmt + clippy + workspace all green.Status: 8/8 standalone width tracks ✅
W1 ✓ W2 ✓ W3 ✓ W4 ✓ W5 ✓ W6 ✓ W7 ✓ W8 ✓.
What's left of the plan (no longer standalone list/detail pages):
The width pass is the breadth-first skeleton; depth + GUI are where it becomes a usable app. D1 (forms — create/edit, CSRF already wired in W0.3) and G1 (master
base.askamatemplate, replacing the inlinewrap_in_doc) are the highest-leverage next steps.🤖 Generated with Claude Code