feat(rm-handlers): W7 — SCM-light (Repository + Changeset, read-only)#17
Merged
Merged
Conversation
W7 of the Redmine Integration Plan. Read-only browse over SCM metadata — no live VCS driver (that's a later sprint per the plan: 'W7 SCM-light (read-only; no Git driver yet)'). # Routes - GET /repositories + /repositories/:id (0x010A project_repository) - GET /changesets + /changesets/:revision (0x0112 project_changeset) # URL keys - Repository: record-key URL (Redmine keys repos by numeric PK; no natural slug — url + scm_type are the only attributes). - Changeset: revision-slug URL (Redmine's /repository/revisions/:rev), percent-encoded via common::encode_path_segment. # DoD pinned by 12 new tests Store (scm.rs, 6): repository + changeset round-trip, NotFound, list empty/populated for each. Handlers (scm.rs, 6): repository list empty-state w/ 0x010A, repo list+detail by record key, repo detail 404; changeset list empty-state w/ 0x0112, changeset list+detail by revision slug, changeset detail 404. # Status: 7/8 width tracks shipped W1 Issue, W2 Project, W3 TimeEntry, W4 User+Role, W5 Taxonomy(3/4), W6 News+WikiPage, W7 Repository+Changeset. Remaining standalone: W8 Query + IssueRelation. Plus deferred nested sets (W4 Member/ MemberRole/Watcher, W6 Comment/Message/Forum/Attachment) and W5 CustomField (ties to D1 forms). cargo fmt --check + cargo clippy --all-targets -- -D warnings + cargo test --workspace all green; 153 tests across 5 crates.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W7 from the Redmine Integration Plan
SCM-light: read-only browse over Repository + Changeset metadata. No live VCS driver — that's a later sprint, exactly as the plan scopes W7 ("read-only; no Git driver yet").
/repositories[+/:id]0x010A project_repository/changesets[+/:revision]0x0112 project_changesetShape
url+scm_type(Git/Subversion/Mercurial).revision+commit_date+comments, keyed byrevision(Redmine's/repository/revisions/:rev).common::{html_escape, encode_path_segment}guards from fix(handlers): XSS in titles/headlines + URL-encode slugs + RM_BIND fail-fast #14.DoD pinned by 12 new tests
6 store (round-trip / NotFound / list per resource) + 6 handler (empty-state class_id, list+detail, 404 per resource). All three CI gates green: 153 tests across 5 crates.
Status: 7 of 8 width tracks shipped
W1 ✓ W2 ✓ W3 ✓ W4 ✓ W5 ✓ W6 ✓ W7 ✓. Remaining standalone: W8 (Query + IssueRelation). Deferred: nested sets (W4 Member/MemberRole/Watcher, W6 Comment/Message/Forum/Attachment), W5 CustomField (ties to D1 forms).
🤖 Generated with Claude Code