feat(rm-handlers): W6 — News + WikiPage handlers#16
Merged
Conversation
W6 of the Redmine Integration Plan, first comms-track concepts. # Routes - GET /news + /news/:id News list / detail (0x0114) - GET /wiki + /wiki/:title WikiPage list / detail (0x010C) # Scope split W6 in the plan groups Comment + News + Message + Forum + WikiPage + Attachment. This PR ships the two TOP-LEVEL content-browsing concepts. The other four are nested or sidecar: - Comment → threads under an Issue or News (W6 followup, lands with the Issue detail journal embedding) - Message + Forum (Board) → forum/thread nest pair (W6 followup) - Attachment → polymorphic sidecar on Issue/Document/Project (W6 followup, also unblocks D5 custom-fields file uploads) # News URL convention News uses record-keyed URL (`/news/:id`) following Redmine's `/news/:id` integer-PK convention — no slug field on the row. # WikiPage URL convention WikiPage uses slug-keyed URL (`/wiki/:title`) following Redmine's `/projects/:proj/wiki/:title` shape, flattened to the top level for MVP since multi-project nesting needs the Member/Membership join that lands in a W2-followup. # DoD pinned by 14 new tests Store (6): - News + WikiPage round-trip - find returns NotFound for unknown - list empty/populated Handlers (8): - News list empty-state w/ class_id 0x0114 - News list with 1 entry visible + record-key href - News detail by record key - News detail 404 - WikiPage list empty-state w/ 0x010C - WikiPage detail by title - WikiPage detail 404 - WikiPage list percent-encodes `A/B testing` → `A%2FB%20testing` # Status: 6/8 width tracks shipped W1 ✓ W2 ✓ W3 ✓ W4 (User+Role) ✓ W5 (3/4) ✓ W6 (2/6) ✓. Remaining: W4 nested (Member/MemberRole/Watcher), W6 nested (Comment/Message/Forum/Attachment), W7 SCM-light, W8 Queries. cargo fmt --check + cargo clippy --all-targets -- -D warnings + cargo test --workspace all green locally; 141 tests across 5 crates.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W6 from the Redmine Integration Plan
First comms-track concepts. Two top-level content-browsing pages.
GET /news[+/:id]0x0114 project_newsGET /wiki[+/:title]0x010C project_wiki_pageScope split
W6 in the plan groups News + WikiPage + Comment + Message + Forum + Attachment. This PR ships the two top-level content-browsing concepts; the others nest or sidecar:
Notable
/news/:id— we hash a stable u64 from the SurrealDB record key fordata-record-id)/wiki/:title) — multi-project nesting (/projects/:proj/wiki/:title) waits for Member/Membership join in a W2 followupcommon::html_escape+common::encode_path_segmentfrom fix(handlers): XSS in titles/headlines + URL-encode slugs + RM_BIND fail-fast #14, so XSS + URL-reserved chars are handledDoD pinned by 14 new tests
rm-store/src/news.rsrm-store/src/wiki_page.rsrm-handlers/src/news.rs0x0114, list with hrefs, detail by key, 404rm-handlers/src/wiki_pages.rs0x010C, detail by title, 404, percent-encoded title in hrefAll three CI gates green: fmt + clippy + cargo test --workspace (141 tests across 5 crates).
Status
6 of 8 width tracks shipped. W1 ✓ W2 ✓ W3 ✓ W4 (User+Role) ✓ W5 (3/4) ✓ W6 (2/6) ✓. Remaining: W4 nested, W6 nested, W7 SCM-light, W8 Queries/Relations.
🤖 Generated with Claude Code