feat(op-canon): Snapshot::concept_by_class_id reverse record lookup#63
Merged
Conversation
Add `Snapshot::concept_by_class_id(id: u16) -> Option<&Concept>` — the reverse lookup returning the full snapshot record for a codebook id, complementing #62's `canonical_concept_name` (which returns only the name via the OGAR map). Where the name-only map suffices for display, this yields the whole Concept — curator classes + class_id_le wire bytes — that corpus-evidence consumers need. Snapshot-backed (covers the OpenProject promoted concepts); the name it carries agrees with the OGAR reverse map, pinned by canonical_concept_name_agrees_with_the_snapshot. - 1 unit test: 0x0102 -> project_work_item record (WorkPackage among the curator classes); every concept round-trips by its own id; unknown -> None. cargo +1.95 fmt / clippy -D warnings / test -p op-canon: 24 unit + 8 doctests green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
Snapshot::concept_by_class_id(id: u16) -> Option<&Concept>— the reverse lookup returning the full snapshot record for a codebook id, complementing #62'scanonical_concept_name(which returns only the name via the OGAR map).Why
The name-only map is enough for display, but corpus-evidence work needs the whole
Concept— its curator classes andclass_id_lewire bytes — that anOption<&'static str>can't carry. This is the id-keyed sibling of the existingconcept(name)andconcept_of_class(curator_class)lookups. Snapshot-backed (covers the OpenProject promoted concepts); the name it carries agrees with the OGAR reverse map, already pinned bycanonical_concept_name_agrees_with_the_snapshot.Tests
0x0102→ theproject_work_itemrecord (withWorkPackageamong its curator classes); every concept round-trips by its own id; unknown id →None.cargo +1.95 fmt --check/clippy --all-targets -D warnings/test -p op-canon: 24 unit + 8 doctests green.Branch note
Follows the merged #62. Per the merged-branch rule,
beautiful-gates-dJo0uwas restarted from the newmain(bd3463f, containing #62) and this single follow-up commit stacked on top — fast-forward push, fresh PR, no overlap with the walledodoo-rs-transcodebranch.🤖 Generated with Claude Code
Generated by Claude Code