chore(op-canon): drop Member/Membership drift pin after OGAR #113 merged#59
Merged
Merged
Conversation
OGAR PR #113 (merged) added `("Member", PROJECT_MEMBERSHIP)` to
OPENPROJECT_ALIASES alongside the existing `Membership` alias. The
`port_and_snapshot_membership_vocab_mismatch_is_known` test I pinned in
#56 was deliberately self-flipping: it asserted `class_id_of("Member") ==
None` so it'd fail the moment OGAR aligned the alias to the corpus name —
forcing the next session to come back and drop the pin. That trigger
fired; this is that drop.
Replaces the pin with the successor positive assertion
`member_and_membership_both_resolve_after_ogar_113`:
- `class_id_of("Member")` → Some(PROJECT_MEMBERSHIP) (OGAR #113)
- `class_id_of("Membership")` → Some(PROJECT_MEMBERSHIP) (kept synonym)
- both equal each other → no vocab drift between OP corpus + port
The overlap drift guard (`port_pull_agrees_with_the_snapshot`) now
covers `Member` too — no silent skip on that name anymore.
Lockfile: `cargo update -p ogar-vocab` → OGAR main @ 991450a (post-#113).
cargo +1.95 test -p op-canon → 19 unit + 5 doctests pass (was 19+5; same
count — same number of tests, just the membership one renamed to its
positive successor). fmt + clippy --all-targets -- -D warnings clean.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the chain: OGAR #113 (merged) added
("Member", PROJECT_MEMBERSHIP)toOPENPROJECT_ALIASESalongside the existingMembership. The pinned drift test I planted in #56 was deliberately self-flipping (assertingclass_id_of("Member") == None) so it'd fail the moment OGAR aligned the alias to the corpus name. That trigger fired; this is the drop.The new test
member_and_membership_both_resolve_after_ogar_113pins that:Memberresolves (OGAR #113 — canonical, matches the OpenProject corpus + Redmine)Membershipstill resolves (deprecated synonym kept for backcompat)The overlap drift guard (
port_pull_agrees_with_the_snapshot) now coversMembertoo — no silent skip on that name anymore.Scope
cargo update -p ogar-vocab→ OGARmainpost-#113 (991450a). No other dep changes.crates/op-canon/src/app.rs— replaces 1 test (the pin) with 1 test (the positive successor); the test count is unchanged.Build
Toolchain
1.95.cargo test -p op-canon→ 19 unit + 5 doctests pass.cargo fmt --check+cargo clippy --all-targets -- -D warningsclean.Cross-refs
Generated by Claude Code