test(ogar-vocab): pin 5-way billable_work_entry convergence (planner↔ERP)#96
Merged
Merged
Conversation
…->ERP)
Adds `billable_work_entry_converges_across_all_five_ports`, the
single-test pin for the planner<->ERP convergence the migration plan
(APP-CODEBOOK-MIGRATION-PLAN.md W0+W1+W2+W3) names "planner times ==
billable hours". Earlier tests pinned partial fan-outs:
- `time_entry_converges_across_planner_and_erp_ports` (4-way: OP, RM,
WoA, SMB) -- from #93.
- `planning_and_erp_converge_on_billable_work_entry` (3-way: OP, RM,
Odoo) -- from #94.
Neither covered all 5 ports. This new test asserts in one place that
OpenProject `TimeEntry`, Redmine `TimeEntry`, Odoo
`account.analytic.line`, WoA `Stundenzettel`, and SMB `Stundenzettel`
all resolve to `class_ids::BILLABLE_WORK_ENTRY` (0x0103). Drift on ANY
of the 5 ports breaks CI here, surfacing the migration plan's W0 table
in code.
Test-only; no API change. cargo check --workspace --all-targets +
cargo test -p ogar-vocab --lib ports:: clean (26 passed; was 25).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
billable_work_entry_converges_across_all_five_portstoogar-vocab::ports— the single-test pin for the planner⟷ERP convergencethat
APP-CODEBOOK-MIGRATION-PLAN.md(W0 + W1 + W2 + W3) names "plannertimes == billable hours". Pins the W0 worked table in code.
Why a new test (the existing ones cover subsets)
time_entry_converges_across_planner_and_erp_portsplanning_and_erp_converge_on_billable_work_entryNeither covers the full 5-port fan-out. This new test asserts in one place
that all five port-bearing apps resolve their own timesheet surface name
to the same canonical concept (
class_ids::BILLABLE_WORK_ENTRY=0x0103):0x0001)TimeEntryOpenProjectPort0x0002)account.analytic.lineOdooPort0x0003)StundenzettelWoaPort0x0004)StundenzettelSmbPort0x0007)TimeEntryRedminePortWhy the pin matters
Per
APP-CLASS-CODEBOOK-LAYOUT.md§1, the low u16 is the shared conceptcurrency — the RBAC + ontology key, the cross-app identity. Five apps
resolving the same low half means a logged planning hour and the
ERP-billed line are one canonical concept — no cross-system join, no
"hours planned" vs "hours invoiced" reconciliation step. Drift on ANY of
the five ports (rename, re-map, lost alias) breaks CI here.
This is the migration plan's "showcase" (W0) generalized to the full set
of ports already shipped (#93 + #94).
Scope
1.95.0(pinned).cargo check --workspace --all-targetsclean.cargo test -p ogar-vocab --lib ports::26 passed; 0 failed (was 25).are RESERVED per the layout doc but minting is gated on the 5+3 codebook
pass; this PR doesn't touch that gate).