feat(ogar-render-askama): T5 — SurrealqlTable (completes the +5 kit)

[AdaWorldAPI]

What

T5 (SurrealqlTable) — the codegen-flavour finisher of the Northstar +5 kit. Stacks on top of #85 (T4); the duplicated T4 commit drops on rebase when #85 merges first.

After this lands, 5/7 ArtifactKind variants are real. Only the deprecated OpenapiSchema (anti-pattern #8) and the roadmap-only NodeGuidRoutingArm remain stubbed.

Direct sibling of T1 (RustStruct) — both are codegen-flavour, both consume &Class at build time, both emit typed source for downstream compilers/engines.

What it emits

Sample render of project_role():

-- ProjectRole — canonical class generated from `ogar_vocab::project_role()`.
-- DO NOT EDIT BY HAND. Re-render via `ogar-render-askama`.

DEFINE TABLE project_role SCHEMAFULL COMMENT "OGAR codebook id 0x0117 (project_role)";

DEFINE FIELD name ON project_role TYPE string;
DEFINE FIELD position ON project_role TYPE int;
DEFINE FIELD permissions ON project_role TYPE string;
DEFINE FIELD memberships ON project_role TYPE array<record<project_membership>> COMMENT "has_many -> project_membership";
DEFINE INDEX idx_name ON project_role FIELDS name;

Mapping

Rails type	SurrealQL TYPE
string / text	string
integer / big_integer / bigint	int
float / double	float
decimal / monetary	decimal
boolean / bool	bool
date / datetime / timestamp	datetime
json / jsonb	object

Association kind	SurrealQL TYPE
belongs_to / has_one	option<record<target>>
has_many / has_and_belongs_to_many	array<record<target>>

Target table is the canonical concept name when it's promoted (tax_policy, project_membership, …) or snake_case'd class_name otherwise.

Reserved-word escape (SurQL-side companion of Rust + TS escapes)

SurrealQL reserves type / value / id / for / select / where / etc. The emitter back-tick-quotes field names that collide:

DEFINE FIELD `type` ON project_actor TYPE string;

project_actor declares an attribute literally named type (Rails STI convention) — the same hazard that bit Rust on codex P1 #78 and TypeScript on T2. Each emitter handles it locally per the per-target convention.

Default index

Classes with a name / subject / title / label primary attribute get a non-unique index on it (idx_<name>). Classes without one (billable_work_entry, etc.) emit no default — consumers add per their own policy.

Tests (+6 T5, 44/44 total)

• surrealql_table_emits_define_table_with_codebook_meta — proof of shape on project_work_item: TABLE name + CODEBOOK comment 0x0102 + DEFINE FIELD per attribute.
• surrealql_table_maps_rails_types_to_surql — project_role's name/string, position/int, permissions/string mapping.
• surrealql_table_emits_record_links_for_family_edges — all 12 billable_work_entry edges emit DEFINE FIELD; at least one option<record<…>> link with snake_case'd target (tax_policy).
• surrealql_table_emits_primary_label_index — project_role gets DEFINE INDEX idx_name ON project_role FIELDS name.
• surrealql_table_escapes_reserved_identifiers — project_actor.type → DEFINE FIELD `type` ON project_actor.
• surrealql_table_default_indexes_only_when_class_has_primary_label — negative pin: billable_work_entry gets no default index.

Workspace check + workspace test green.

Note on op-surreal-ast

This crate emits DDL for the canonical layer's own consumption (render(class, ArtifactKind::SurrealqlTable)). The byte-identical-output pin in openproject-nexgen-rs::op-surreal-ast still holds for that crate's own emission — the two paths are sibling, not competing. See Northstar plan §2.1 / §2.4 for the call-site picture; C3 (the op-surreal-ast::from_class_view adapter) is the bridge.

+5 kit complete

PR	Kind	Flavour
T1	RustStruct	codegen ✅
T2	HtmlListView	render ✅
T3	HtmlDetailView	render ✅
T4	HtmlForm	render ⏳ (#85)
T5	SurrealqlTable	codegen — this PR

C-series consumer wirings (C1–C5) are the next move; each PR is small and lands across the openproject-nexgen-rs / redmine-rs repos.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61b2c142c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Submit edit forms with a valid HTML method

When callers use the documented edit path (FormSource.method is described and tested with "patch"), this value is written directly into the HTML method attribute. Browsers only submit forms with GET/POST, so PATCH needs a POST form plus a hidden method override; otherwise these generated edit forms submit with the wrong method and miss PATCH routes.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Preserve association ownership in Surreal fields

For classes with HasMany/HasOne associations such as project_work_item.journals, ogar_vocab::AssociationKind marks those as non-owning, but this branch creates fields on the current table, and the wildcard also makes every BelongsTo optional even when optional is unset or false. That corrupts the generated schema by storing inverse collections and allowing required FK records to be absent; emit fields only for owning BelongsTo associations and wrap option<...> based on Association::optional.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Quote non-bare SurrealQL table identifiers

When rendering an unpromoted Class whose source name contains dots or namespaces, such as Odoo sale.order, this fallback lowercases and emits the raw string into DEFINE TABLE and ON. That produces invalid SurrealQL like DEFINE TABLE sale.order; run the fallback through a SurrealQL identifier quoting helper, including backtick escaping, instead of writing it bare.

Useful? React with 👍 / 👎.