feat(ogar-vocab): commerce/ERP canonical wave — 6 cross-curator concepts (OSB ↔ Odoo)#64
Merged
Merged
Conversation
…pts (OSB <-> Odoo) Lands the parallel session's lance-graph-ontology::ar_shape upstream candidates into OGAR's CODEBOOK. The parallel session detected these six concepts on the OSB and Odoo corpora with structural evidence; OGAR is in this session's MCP reach but not theirs, so this is the cross-session bridge. | Canonical | id | OSB | Odoo | |------------------------|---------|-----------------|---------------------| | commercial_line_item | 0x0007 | InvoiceLineItem | account_move_line | | commercial_document | 0x0008 | Invoice | account_move | | tax_policy | 0x0009 | Tax | account_tax | | billing_party | 0x000A | Client | res_partner | | payment_record | 0x000B | Payment | account_payment | | currency_policy | 0x000C | Currency | res_currency | 0x0005-0x0006 left reserved for ProjectStatus + ProjectType (#63 in flight). Codebook ids are sequential after #63's range so neither PR needs to rebase regardless of merge order. - CODEBOOK additions: 6 entries with domain-grouped block comments. - canonical_concept resolver: 6 promoted arms covering OSB-side, Odoo- side (both dotted and ruff-underscored forms), PascalCase canonical class names, and snake_case canonical names. Pinned by commerce_resolver_collapses_osb_and_odoo_curator_divergence. - 6 canonical class functions with: * Language::Unknown per the synthetic-class doctrine, * canonical_concept set so .canonical_id() round-trips, * universal typed attributes (decimal/string/date/boolean), * the obvious cross-references between commerce concepts as family edges (LineItem -> Document, LineItem -> TaxPolicy, Document -> LineItem + Party + Currency, Payment -> Party + Document). - tax_policy closes the forward reference from billable_work_entry().classified_by which already targeted 'TaxPolicy'. 3 new unit tests: - commerce_canonical_classes_are_promoted_into_the_codebook — shape + language + codebook presence + typed attrs. - commerce_resolver_collapses_osb_and_odoo_curator_divergence — every alias resolves to the right codebook id; 6 ids all distinct. - commerce_class_family_edges_target_canonical_concepts — internal cross-references stay canonical-to-canonical, no curator surface leak. No real-corpus assertions from this session — OSB and Odoo corpora are the parallel session's territory; they can add detection tests in follow-up via their own MCP path. The codebook + canonical-class shapes are now landed in OGAR for them to consume. ogar-vocab 33 (+3 commerce); clippy clean; disk 23 GB free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-session bridge — commerce/ERP canonical wave
Lands the parallel session's
lance-graph-ontology::ar_shapeupstream candidates into OGAR's CODEBOOK. They detected the six concepts on the OSB and Odoo corpora with structural evidence (their branchclaude/hydrate-dolce-dul-owl-Ce9Oaat4d469ce, 19 ar_shape tests green); OGAR is in this session's MCP reach but not theirs — so this is the bridge.commercial_line_item0x0007InvoiceLineItemaccount_move_linecommercial_document0x0008Invoiceaccount_movetax_policy0x0009Taxaccount_taxbilling_party0x000AClientres_partnerpayment_record0x000BPaymentaccount_paymentcurrency_policy0x000CCurrencyres_currencyID coordination:
0x0005–0x0006reserved for ProjectStatus + ProjectType (#63 in flight). Commerce ids are sequential after that range so neither PR needs to rebase regardless of merge order.What
CODEBOOKadditions: 6 entries with domain-grouped block comments.canonical_conceptresolver: 6 promoted arms covering OSB-side, Odoo-side (both dotted and ruff-underscored forms), PascalCase canonical class names, and snake_case canonical names.Language::Unknownper the synthetic-class doctrine,canonical_conceptset so.canonical_id()round-trips,tax_policycloses the forward reference frombillable_work_entry().classified_bywhich already targetedTaxPolicy.Tests
commerce_canonical_classes_are_promoted_into_the_codebook— shape + language + codebook presence + typed attrs for all six.commerce_resolver_collapses_osb_and_odoo_curator_divergence— every OSB-side, Odoo-side, dotted/underscored, PascalCase/snake_case alias resolves to the right codebook id; all 6 ids distinct.commerce_class_family_edges_target_canonical_concepts— internal cross-references stay canonical-to-canonical (no curator surface leak).No real-corpus assertions from this session — OSB and Odoo corpora are the parallel session's territory; they can land detection / lift tests additively via their own path. The codebook + canonical-class shapes are now in OGAR for them to consume.
Green
ogar-vocab33 (+3 commerce) · clippy clean · disk 23 GB free.OGAR codebook is now 10 entries (12 with #63 merged)
0x00010x00020x00030x00040x00050x00060x00070x00080x00090x000A0x000B0x000C🤖 Generated with Claude Code