Correct the exports/ "latent re-vendor bug" false premise — staging-tier model#108
Merged
Merged
Conversation
…/ is a staging tier Verifying the queued "migrate 11 Accounting files" task caught that its founding premise was factually wrong. The PR #107 claim: 11 OGAR-produced TTLs in vocab/imports/ogit/NTO/Accounting/ are "at re-vendor-overwrite risk" and should migrate to exports/. What verification found: those 11 files are COMMITTED TO THE AdaWorldAPI/OGIT FORK — commit c5dc1b8 "shrink 3-hop Odoo lookups — promoted attrs + shortcut verbs + FiscalJurisdiction codebook", on the fork's master, pushed. imports/ faithfully mirrors the fork; the re-vendor recipe copies FROM the fork, so it PRESERVES them. There was never a data-loss risk. No migration. Operator resolved the genuine question (what is exports/ FOR) to the STAGING-TIER model: producer → exports/ (review, CI) → promote to OGIT fork → re-vendor → imports/ → consumers read imports/ - exports/ = produced-but-not-yet-promoted; transient workbench. - AdaWorldAPI/OGIT fork = enriched canonical store (upstream + promoted). - imports/ = faithful mirror of the enriched fork. - consumers read ONLY imports/. The 11 Accounting files are a COMPLETED promotion (the worked example of the model run to its end), correctly mirrored — not stranded. Changes: * vocab/exports/PROVENANCE.md — rewritten STAGING TIER v1: the model diagram, why-stage-not-commit-direct, and a correction block replacing the false "migration note". * vocab/exports/ogit/README.md — staging-tier framing. * docs/ODOO-DIGEST-TO-OGIT.md — pipeline diagram shows exports → promote → imports; §2 rewritten to the staging-tier model with the c5dc1b8 correction; the two stale correction-note + blocker rows fixed. * docs/OGIT-DOMAIN-LIFT-CATALOGUE.md — Accounting row notes the 11 are promoted-to-fork (completed), not stranded; upstream author count corrected to 25 (Viktor Voss / Gibson Xavier / Moritz Vannahme). * .claude/board/EPIPHANIES.md — new FINDING (the false premise + the staging-tier resolution + two lessons: verify-the-target-before- claiming-a-bug, and a-correction-can-itself-need-correcting); prior "Three corrections" entry regraded PARTIALLY SUPERSEDED (corrections 1 & 2 stand; correction 3's bug-claim superseded). No code changes; tests still 16/16 default, 20/20 with --features xsd.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
A correction. Following up #107's
vocab/exports/scaffold, I went todo the "migrate the 11 Accounting files" task — and verifying the
target first caught that the task's founding premise was factually
wrong.
The false premise
#107 claimed: 11 OGAR-produced TTLs in
vocab/imports/ogit/NTO/Accounting/are "at re-vendor-overwrite risk"and belong in
exports/.Verification found the opposite. Those 11 files are committed to
the AdaWorldAPI/OGIT fork — commit
c5dc1b8("shrink 3-hop Odoolookups — promoted attrs + shortcut verbs + FiscalJurisdiction
codebook"), on the fork's
master, pushed.imports/faithfullymirrors the fork; the re-vendor recipe copies from the fork, so it
preserves them. There was never a data-loss risk, and they are
not a migration candidate.
The resolution (operator-decided)
vocab/exports/is a staging tier, not a permanent home:The 11 Accounting files are a completed promotion — the worked
example of this pipeline run to its end, correctly mirrored in
imports/.exports/stays empty until a producer stages contentthat hasn't been promoted yet.
Changes
vocab/exports/PROVENANCE.md— rewritten to STAGING TIER v1: themodel diagram, the why-stage-not-commit-direct rationale, and a
correction block replacing the false migration note.
vocab/exports/ogit/README.md— staging-tier framing.docs/ODOO-DIGEST-TO-OGIT.md— pipeline diagram now showsexports → promote → imports; §2 rewritten to the staging-tiermodel with the
c5dc1b8correction; two stale rows fixed.docs/OGIT-DOMAIN-LIFT-CATALOGUE.md— Accounting row notes the 11are promoted-to-fork (completed), not stranded; upstream author
count corrected to 25.
.claude/board/EPIPHANIES.md— new FINDING (the false premise + thestaging-tier resolution + two lessons); prior "Three corrections"
entry regraded PARTIALLY SUPERSEDED.
Two lessons logged
git logon the OGIT clone falsified the "at risk" claim — and would have
prevented a migration that broke the imports↔fork bijection and
duplicated 11 files.
handles this: regrade in place, append the correction.
Tests
No code changes.
cargo test -p ogar-from-schema: 16/16 default,20/20 with
--features xsd.Generated by Claude Code