Skip to content

Correct the exports/ "latent re-vendor bug" false premise — staging-tier model#108

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/medcare-bridge-lance-graph-wmx76z
Jun 22, 2026
Merged

Correct the exports/ "latent re-vendor bug" false premise — staging-tier model#108
AdaWorldAPI merged 1 commit into
mainfrom
claude/medcare-bridge-lance-graph-wmx76z

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What this is

A correction. Following up #107's vocab/exports/ scaffold, I went to
do the "migrate the 11 Accounting files" task — and verifying the
target first caught that the task's founding premise was factually
wrong
.

The false premise

#107 claimed: 11 OGAR-produced TTLs in
vocab/imports/ogit/NTO/Accounting/ are "at re-vendor-overwrite risk"
and belong in exports/.

Verification found the opposite. Those 11 files are committed to
the AdaWorldAPI/OGIT fork — commit c5dc1b8 ("shrink 3-hop Odoo
lookups — promoted attrs + shortcut verbs + FiscalJurisdiction
codebook"), on the fork's master, pushed. imports/ faithfully
mirrors the fork; the re-vendor recipe copies from the fork, so it
preserves them. There was never a data-loss risk, and they are
not a migration candidate.

The resolution (operator-decided)

vocab/exports/ is a staging tier, not a permanent home:

producer ──► vocab/exports/ogit/  (review, CI: round-trip + bijection + drift)
                  │  promote (commit to OGIT fork on a branch, PR there)
                  ▼
             AdaWorldAPI/OGIT fork  (enriched canonical store: upstream + promoted)
                  │  re-vendor (cp -r /OGIT/NTO/. vocab/imports/ogit/NTO/)
                  ▼
             vocab/imports/ogit/   (faithful SHA-pinned mirror)
                  │
                  ▼
             consumers read ONLY imports/

The 11 Accounting files are a completed promotion — the worked
example of this pipeline run to its end, correctly mirrored in
imports/. exports/ stays empty until a producer stages content
that hasn't been promoted yet.

Changes

  • vocab/exports/PROVENANCE.md — rewritten to STAGING TIER v1: the
    model diagram, the why-stage-not-commit-direct rationale, and a
    correction block replacing the false migration note.
  • vocab/exports/ogit/README.md — staging-tier framing.
  • docs/ODOO-DIGEST-TO-OGIT.md — pipeline diagram now shows
    exports → promote → imports; §2 rewritten to the staging-tier
    model with the c5dc1b8 correction; two stale rows fixed.
  • docs/OGIT-DOMAIN-LIFT-CATALOGUE.md — Accounting row notes the 11
    are promoted-to-fork (completed), not stranded; upstream author
    count corrected to 25.
  • .claude/board/EPIPHANIES.md — new FINDING (the false premise + the
    staging-tier resolution + two lessons); prior "Three corrections"
    entry regraded PARTIALLY SUPERSEDED.

Two lessons logged

  1. Verify the target before claiming a bug about it. One git log
    on the OGIT clone falsified the "at risk" claim — and would have
    prevented a migration that broke the imports↔fork bijection and
    duplicated 11 files.
  2. A correction can itself need correcting. The append-only ledger
    handles this: regrade in place, append the correction.

Tests

No code changes. cargo test -p ogar-from-schema: 16/16 default,
20/20 with --features xsd.


Generated by Claude Code

…/ is a staging tier

Verifying the queued "migrate 11 Accounting files" task caught that its
founding premise was factually wrong.

The PR #107 claim: 11 OGAR-produced TTLs in
vocab/imports/ogit/NTO/Accounting/ are "at re-vendor-overwrite risk"
and should migrate to exports/.

What verification found: those 11 files are COMMITTED TO THE
AdaWorldAPI/OGIT FORK — commit c5dc1b8 "shrink 3-hop Odoo lookups —
promoted attrs + shortcut verbs + FiscalJurisdiction codebook", on the
fork's master, pushed. imports/ faithfully mirrors the fork; the
re-vendor recipe copies FROM the fork, so it PRESERVES them. There was
never a data-loss risk. No migration.

Operator resolved the genuine question (what is exports/ FOR) to the
STAGING-TIER model:

  producer → exports/ (review, CI) → promote to OGIT fork
           → re-vendor → imports/ → consumers read imports/

- exports/ = produced-but-not-yet-promoted; transient workbench.
- AdaWorldAPI/OGIT fork = enriched canonical store (upstream + promoted).
- imports/ = faithful mirror of the enriched fork.
- consumers read ONLY imports/.

The 11 Accounting files are a COMPLETED promotion (the worked example
of the model run to its end), correctly mirrored — not stranded.

Changes:

* vocab/exports/PROVENANCE.md — rewritten STAGING TIER v1: the model
  diagram, why-stage-not-commit-direct, and a correction block
  replacing the false "migration note".
* vocab/exports/ogit/README.md — staging-tier framing.
* docs/ODOO-DIGEST-TO-OGIT.md — pipeline diagram shows
  exports → promote → imports; §2 rewritten to the staging-tier model
  with the c5dc1b8 correction; the two stale correction-note + blocker
  rows fixed.
* docs/OGIT-DOMAIN-LIFT-CATALOGUE.md — Accounting row notes the 11 are
  promoted-to-fork (completed), not stranded; upstream author count
  corrected to 25 (Viktor Voss / Gibson Xavier / Moritz Vannahme).
* .claude/board/EPIPHANIES.md — new FINDING (the false premise + the
  staging-tier resolution + two lessons: verify-the-target-before-
  claiming-a-bug, and a-correction-can-itself-need-correcting); prior
  "Three corrections" entry regraded PARTIALLY SUPERSEDED (corrections
  1 & 2 stand; correction 3's bug-claim superseded).

No code changes; tests still 16/16 default, 20/20 with --features xsd.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@AdaWorldAPI AdaWorldAPI merged commit 1c95bf2 into main Jun 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants