finished assignment but did not address the 3month time passing - wil…#13
Open
SuzHarrison wants to merge 1 commit intoAda-C5:masterfrom
Open
finished assignment but did not address the 3month time passing - wil…#13SuzHarrison wants to merge 1 commit intoAda-C5:masterfrom
SuzHarrison wants to merge 1 commit intoAda-C5:masterfrom
Conversation
|
Would have liked to see these methods inside a class with an initialize method, though I didn't specifically ask for it. :) |
| @workers.push("three") | ||
| @workers.push("four") | ||
| @workers.push("five") | ||
| @workers.push("six") |
There was a problem hiding this comment.
Pushing these as words is definitely harder. Instead, you could have said:
6.times do |i|
@workers.push(i)
end
or perhaps
(1..6).each do
^^ I think that one works? Maybe?
|
Overall, this looks good and the logic is sound. The only changes would be around making your solution as a class and then creating an instance of that class for testing. I can walk through this with you sometime if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make a loop to get the initial Stack and Queue set to 6 and 10 respectively but it was not testing successfully so opted for pushing these one by one. I put in some puts statements so I could see what the program was returning long the way and to verify that the roll_dice method was always generating a random number.