Seabay/master - finished the project!#13
Open
kdefliese wants to merge 466 commits intoAda-C4:seabay/masterfrom
Open
Seabay/master - finished the project!#13kdefliese wants to merge 466 commits intoAda-C4:seabay/masterfrom
kdefliese wants to merge 466 commits intoAda-C4:seabay/masterfrom
Conversation
There was a problem hiding this comment.
Consistency in how things are named/referenced is helpful for those consuming your code. I like your use of the pattern describe "VERB #method" in your specs and suggest using that here and on line 91 as well.
|
OMG I just read the comment for this PR. 👏 💖 🎵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://seabay.herokuapp.com/
Look at this site, isn't it neat?
Wouldn't you think our test coverage's complete?
Wouldn't you think we're the team
The team who has everything?
Look at this trove, treasures untold
How many merchants can one website hold?
Looking around here you'd think
Sure, Seabay's got everything
We've got gadgets and gizmos aplenty
We've got whozits and whatzits galore
You want thingamabobs? We've got twenty!
But who cares? No big deal,
You want code
I wanna be where the models are
I wanna see, wanna see them querying
Messing around in those
What do you call 'em? Oh, databases
Coding in Ruby you won't get too far
Rails is required for awesome websites
Scrolling along down a
What's that word again?
Responsive page
Up where they CRUD, up where they SCRUM
Up where they code all day in the sun (instead of in the dark)
Wandering free
Wish we could be, done with Betsy
-- with love from Ricky, Sarah, Desiree and Katherine