Audrey's final MediaRanker#28
Open
Dreedle wants to merge 45 commits intoAda-C4:ald/masterfrom
Dreedle:ald/master
Open
Audrey's final MediaRanker#28Dreedle wants to merge 45 commits intoAda-C4:ald/masterfrom Dreedle:ald/master
Dreedle wants to merge 45 commits intoAda-C4:ald/masterfrom
Dreedle:ald/master
Conversation
…top ten yet). Did put in some bootstrap classes in anticipation of the future
…ation for bootstrap
…s (bootstrap still has not been added so they don't look like anything yet)
… if new album is not saved
There was a problem hiding this comment.
It's not much of an issue to have this included in the project repo, although you could have put this .rspec file in your home directory and it would work for your local machine (across all projects).
|
Excellent use of many small, focused commits! Overall it's great, keep it up! |
Author
|
The comments about specific ways to do testing were really helpful! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did accomplish:
-The requirements for waves 1, 2 and 3.
-98% code coverage on tests. (The model tests do not have complete coverage because I did not write a test for my method to order the items by ranking. I figured that method is entirely ActiveRecord, and I only wrote it to make the code in the views more concise.)
-Using shared examples to do rspec tests.
Did not accomplish:
-Drying out views/controllers with polymorphic path. Once I had written the tests, I decided that ship had sailed.
-On index page for books, albums and movie, the spacing of table rows look slightly different. Chalking it up to dynamicity of the table rows, but not entirely sure. Couldn't find a css difference.