Space - Lee#32
Open
theomoondev wants to merge 4 commits intoAda-C13:masterfrom
Open
Conversation
CheezItMan
reviewed
Sep 14, 2020
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Lee. You hit all the learning goals here. Well done. Let me know if you have any questions.
Comment on lines
+3
to
5
| # Time Complexity: O(n), where n is the length of the string | ||
| # Space Complexity: O(n) | ||
| def balanced(string) |
| @rear = -1 | ||
| end | ||
|
|
||
| def enqueue(element) |
Comment on lines
+17
to
+23
| elsif @rear == @size - 1 && @front != 0 # rear needs to wrap around | ||
| @rear = 0 | ||
| @store[@rear] = element | ||
| else | ||
| @rear += 1 | ||
| @store[@rear] = element | ||
| end |
There was a problem hiding this comment.
This could be simplified a bit.
Suggested change
| elsif @rear == @size - 1 && @front != 0 # rear needs to wrap around | |
| @rear = 0 | |
| @store[@rear] = element | |
| else | |
| @rear += 1 | |
| @store[@rear] = element | |
| end | |
| else | |
| @rear = (@rear + 1) % @store.length | |
| @store[@rear] = element | |
| end |
Comment on lines
+36
to
+40
| elsif @front == @size - 1 # front needs to wrap around | ||
| @front = 0 | ||
| else | ||
| @front += 1 | ||
| end |
There was a problem hiding this comment.
See above for a way to simplify this.
| @@ -1,19 +1,22 @@ | |||
| class Stack | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
push(element): Adds an element to the top of the stack;pop: Removes and returns the element on top of the stack;is_empty: Returns true is the stack has no elements, and false otherwise;peekortop: Returns but does not remove the top element of the stack;size: Returns the number of elements on the stackenqueue(element): Puts an element at the back of the queue;dequeue: Removes and returns the element at the front of the queue;is_empty: Returns true if the queue is empty and false otherwise;front: Returns the element at the front, but leaves the queue unchanged;size: Returns the number of elements in the queue.OPTIONAL JobSimulation