Liv - Space#20
Open
mulhoo wants to merge 3 commits intoAda-C13:masterfrom
Open
Conversation
CheezItMan
reviewed
Sep 9, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Liv, Nice work, you hit the learning goals here. Well done. Take a look at my comments and let me know if you have questions, but this is quite well done.
| @@ -1,13 +1,25 @@ | |||
| require_relative './stack.rb' | |||
There was a problem hiding this comment.
Just a note on missing comprehension question answers.
Comment on lines
+6
to
+10
| pairs = { | ||
| ')' => '(', | ||
| '}' => '{', | ||
| ']' => '[' | ||
| } |
Comment on lines
+3
to
5
| # Time Complexity: on | ||
| # Space Complexity: on | ||
| def balanced(string) |
| @front = @back = -1 | ||
| end | ||
|
|
||
| def enqueue(element) |
| @back = (@back+1) % @store.length | ||
| end | ||
|
|
||
| def dequeue |
There was a problem hiding this comment.
You should also check to see if the Queue is empty and you try to dequeue.
| @@ -1,19 +1,23 @@ | |||
| require_relative 'linked_list' | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation