Keep the site accurate: sitemap dates and Folio's licence - #25
Merged
Conversation
jasonodoom
changed the title
The dates said 19 August while two of the three pages had changed on the 20th. A sitemap that misreports freshness is worse than one that says nothing, because crawlers learn to disregard it. The build now asks git when each page last changed.
The line said Folio is proprietary, which stops being true at release and would then need remembering. The point it was making does not depend on the licence: checking a receipt does not involve Folio at all, which is the stronger claim and true either way.
It counted entries changed, so a correct rebuild reported "0 of 3", which read exactly like a pattern that had stopped matching. It now counts entries dated, and fails the build when a configured page is missing from the sitemap instead of passing silently.
Contributor
Author
|
Rebased onto main after #24. Found a defect in the stamper while verifying: it counted entries changed, so a clean rebuild reported It now counts entries dated, and exits 1 when a configured page is absent from the sitemap. Verified by drifting a URL (build fails, exit 1) and restoring it (exit 0). Added five tests, including one pinning that |
jasonodoom
force-pushed
the
sitemap-freshness
branch
from
September 6, 2026 07:30
a3c160d to
cf1c268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways the site was drifting from the truth.
The sitemap misreported freshness. It claimed all three pages were
last modified on 19 August; two changed on the 20th when the icon links
went in. A sitemap that misreports freshness is worse than one that says
nothing, because crawlers learn to disregard the signal.
npm run buildnow runsscripts/stamp-sitemap.mjs, which asks git wheneach page last changed and stamps
dist/sitemap.xml. Verified bycorrupting all three dates to 1999-01-01 and rebuilding:
A shallow clone with no git history is not a build failure; existing
dates stand.
llms.txt described Folio's licence. It said "Folio itself is
proprietary", which is true today and stops being true at release, so it
would need remembering at exactly the busiest moment. The point that
sentence was making never depended on the licence:
That is accurate in both states, and it is the stronger claim.
npm testpasses (169 tests).