feat(eval): mark cells carried forward from a previous run - #44
Merged
Conversation
Merging an existing manifest supports running one model at a time, and that stays. Doing it silently does not: the 17 and 24 August reports listed ten cells when five ran and the artifact said nothing. Carried cells are now named in the manifest, marked in the report and warned about at generation time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval-livemerges its manifest with whatever is already in the output directory, so a run can be assembled one model at a time. That is deliberate and stays. Doing it invisibly does not: the 17 and 24 August reports listed ten cells when five ran, and nothing in the artifact said so.Cells present in the output directory but not measured by the invocation are now:
carriedForwardThis covers directories with no manifest entry as well, which
loadCellsaggregates using the directory name. Those previously reached the results table with no roster entry at all.Regression test drives
runLiveEvalagainst a planted stray directory rather than the formatter alone.