Skip to content

fix: add missing autoclosebracket keymap(paired bracket deletion) - #2472

Merged
bajrangCoder merged 2 commits into
mainfrom
fix/autoclosebracket
Jul 10, 2026
Merged

bajrangCoder merged 2 commits into
mainfrom
fix/autoclosebracket

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

Closes: #2462

@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds the missing CodeMirror bracket-deletion keymap. The main changes are:

  • Adds closeBracketsKeymap when autoCloseBrackets is enabled.
  • Keeps the normal keymap path unchanged when auto-close is disabled.
  • Extends editor tests to pass base extension options.
  • Adds tests for paired bracket Backspace behavior.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
src/cm/baseExtensions.ts Adds closeBracketsKeymap behind the existing autoCloseBrackets option.
src/test/editor.tests.js Adds bracket Backspace tests and a trailing optional helper argument for base extension options.

Reviews (1): Last reviewed commit: "fix" | Re-trigger Greptile

@bajrangCoder
bajrangCoder merged commit ff93bf2 into main Jul 10, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Jul 10, 2026
@bajrangCoder
bajrangCoder deleted the fix/autoclosebracket branch July 10, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Missing autoCloseBrackets feature in Automated Nightly Build

1 participant