Conversation
Greptile SummaryThis PR makes several editor display options update dynamically. The main changes are:
Confidence Score: 4/5This should be fixed before merging.
src/lib/editorManager.js Important Files Changed
Reviews (2): Last reviewed commit: "feat: Added bracket and highlight Compar..." | Re-trigger Greptile |
| }, | ||
| { | ||
| keys: ["autoCloseBrackets", "bracketMatching"], | ||
| compartments: [bracketCompartment], |
There was a problem hiding this comment.
This dynamic option now owns the compartmented bracket extensions, but editor states still get the same bracket and highlight extensions from the static base extension path. When a user turns autoCloseBrackets, bracketMatching, highlightActiveLine, or highlightSelectionMatches off, applyOptions() can remove only the compartmented copy. The unmanaged copy remains active in the editor state, so the setting can still appear changed while the editor keeps the old bracket or highlight behavior. These extensions need a single owner so runtime setting changes can fully remove them.
| }, | ||
| { | ||
| keys: ["highlightActiveLine", "highlightSelectionMatches"], | ||
| compartments: [highlightCompartment], |
There was a problem hiding this comment.
This spec updates the main highlightActiveLine() extension, but the active-line gutter marker is configured through the line-number extension path. When highlightActiveLine is turned off, this listener only reconfigures highlightCompartment, so the gutter extension can keep using the old value and continue highlighting the active line in the gutter. The setting update needs to refresh both owners of active-line highlighting.
|
This is different thing, not the fix for linked issue. |
|
Okay, no problem! It seems I did go off track while creating this PR. Sorry. |
No description provided.