Skip to content

chore(CI): enhance PR workflows with trusted PR check and permission adjustments - #2464

Merged
UnschooledGamer merged 4 commits into
Acode-Foundation:mainfrom
UnschooledGamer:feat/enhance-ondemand-workflows
Jul 9, 2026
Merged

UnschooledGamer merged 4 commits into
Acode-Foundation:mainfrom
UnschooledGamer:feat/enhance-ondemand-workflows

Conversation

@UnschooledGamer

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the preview-release workflows for PR handling. The main changes are:

  • Adds a trusted-PR input to the reusable nightly build.
  • Passes only the required signing/build secrets to the reusable workflow.
  • Lowers the caller workflow contents permission to read.
  • Moves preview success comments from the reusable workflow to the caller workflow.

Confidence Score: 4/5

The fork PR preview path can fail during cleanup after skipping signing/build file creation.

  • The new trusted-PR condition prevents the secret files from being written for fork PRs.
  • The later cleanup still assumes those files exist.
  • The permission and comment changes look consistent with the jobs that use them.

.github/workflows/nightly-build.yml

Important Files Changed

Filename Overview
.github/workflows/nightly-build.yml Adds required workflow-call secrets and skips writing signing/build files for untrusted PRs, but leaves cleanup assuming those files exist.
.github/workflows/on-demand-preview-releases-PR.yml Adjusts permissions, passes explicit secrets, sends the trusted-PR flag, and handles preview status comments in the caller workflow.

Reviews (1): Last reviewed commit: "feat: add required secrets for keystore ..." | Re-trigger Greptile

Comment thread .github/workflows/nightly-build.yml
@UnschooledGamer
UnschooledGamer merged commit 88cc16c into Acode-Foundation:main Jul 9, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Jul 9, 2026
@UnschooledGamer UnschooledGamer moved this from Done to 🫡 Done by Community in The Code Board - Acode Jul 9, 2026
7HR4IZ3 pushed a commit to cyber-sight/Acode that referenced this pull request Aug 25, 2026
…adjustments (Acode-Foundation#2464)

* feat: enhance PR workflows with trusted PR check and permission adjustments

* feat: specify secrets for trigger_builder in on-demand preview release workflow

* feat: add required secrets for keystore and build JSON in nightly build workflow

* add: check for keystore & build.json cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community enhancement New feature or request

Projects

Status: 🫡 Done by Community

Development

Successfully merging this pull request may close these issues.

1 participant