Skip to content

acode.waitForPlugin shouldn't return undefined #2938

Description

@blanhhy

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

In the current implementation, after waiting for the target plugin to finish loading, resolve() is called instead of resolve(true):

Acode/src/lib/acode.js

Lines 702 to 707 in b7dbe3d

[onPluginLoadCallback](pluginId) {
if (this.#pluginWatchers[pluginId]) {
this.#pluginWatchers[pluginId].resolve();
delete this.#pluginWatchers[pluginId];
}
}

which contradicts the documentation’s description that it returns a Promise<boolean>:

Image

Environment

not matter

If applicable, add mockups / screenshots regarding your vision

No response

If applicable, attach your Acode.log file to this issue.

Acode.log

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions