Repository navigation
fix(oauth): share encrypted state across hosted MCP replicas - #965
Merged
acedatacloud-dev merged 2 commits intoOct 8, 2026
Merged
Conversation
Germey
approved these changes
Oct 8, 2026
acedatacloud-dev
marked this pull request as ready for review
October 8, 2026 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the same two-replica OAuth race found in the account MCP across the other hosted MCP implementations. The shared source now persists exact DCR client registrations, pending PKCE state, single-use authorization codes, and MCP revocation markers in encrypted Redis state. Unknown client IDs are rejected instead of receiving a fabricated callback URI.
scripts/sync_oauth.pydistributes one OAuth provider source to 28 packages and one state-store source to 31 packages, including the three local provider variants. The 25 currently active production Deployments point to the existing OAuth Redis service and use separate per-service encryption keys. The deployment helper creates each key once, marks the Deployment, refuses silent key rotation, waits for Redis, and verifies the updated Deployment with a 900-second rollout gate. Sora remains at zero replicas; six packages without active source Deployments receive only the library fix.Dependency and rollout
The old live-only
mcp-seedream:1Deployment has no current monorepo manifest; the publicseedream.mcp.acedata.cloudingress targets the managedmcp-seedream-proService covered here.Validation
scripts/sync_oauth.py --check; OAuth contract check; root unittest suite and seven focused generator/deploy tests passed.sh -n; representative manifests passed Kubernetes server-side dry run.Rollback
Keep the per-service Secrets and Redis data. Reverting a service image leaves existing durable API Credentials usable, but reconnect reliability returns to the old per-Pod behavior until its new image is restored.