fix(admin): create-playtest form validation + layout UX - #9
Merged
anggorodewanto merged 1 commit intoJul 15, 2026
Merged
Conversation
Six fixes to the Create/Edit Playtest form:
- Pin the step actions bar to the bottom on all steps (flex column +
margin-top:auto) so it no longer floats up on the shorter steps 2/3.
- Add client-side slug format validation (^[a-z0-9][a-z0-9-]{2,63}$,
onChange) so a malformed slug is caught inline instead of round-tripping
to the backend.
- Validate banner image URL onBlur (a URL is invalid mid-type).
- Move the submit-error Alert banner above the Card/stepper and give it
showIcon (error icon + color).
- Make auto-approve limit mandatory when Auto-Approve is on: required
asterisk + short "Must be between 1 and 100000" message on empty
(out-of-bounds keeps the byte-exact server message).
- Make initial code quantity mandatory for AGS Campaign: required
asterisk + inline "Must be between 1 and 50000", blocking Next instead
of falling through to the server-side banner.
Adds tests for the empty auto-approve-limit and required initial-code-
quantity cases. admin vitest (113) + eslint green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six fixes to the Create/Edit Playtest form:
Adds tests for the empty auto-approve-limit and required initial-code- quantity cases. admin vitest (113) + eslint green.