feat(adt): surface build_type + grey out non-downloadable smartbuilds in picker - #5
Merged
Merged
Conversation
… in picker ADT-eng added a `build_type` discriminator to the builds-list response. Confirmed live (develop.blackbox.accelbyte.io v1.35.0, ns avengers): values are `buildinfo` (a real, downloadable build) and `smartbuild` (a SmartBuild entry that cannot mint a download URL). - pkg/adt: Build.BuildType field + Build.Downloadable() helper (empty/unknown => allowed; only an explicit non-buildinfo type is blocked, so legacy ADT drops never wholesale-disable the picker); http.go parses build_type. - proto: ADTBuild.build_type (field 6); adtBuildToProto maps it. - admin picker: per-build build_type tag (green for buildinfo) + greys out / disables selection of non-buildinfo builds. List stays unfiltered (both types shown); ADT's ?buildType= filter deliberately not sent. - tests: http_test (buildinfo + smartbuild pass-through + Downloadable), TestListADTBuilds_MapsBuildType, federated-element picker grey-out case. - docs: PRD 4.8.3 + ListADTBuilds row, cli.md, STATUS_M5 C15. Additive response field — no migration, no new RPC, smoke harness green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADT-eng added a
build_typediscriminator to the builds-list response. Onlybuildinfobuilds can mint a download URL;smartbuildentries cannot. Surface it through the stack and grey out non-downloadable builds in the admin picker.Confirmed live against
develop.blackbox.accelbyte.iov1.35.0 (models.BuildSummary.build_type) + a real probe of nsavengers: 2buildinfo, 1smartbuild.Changes
Build.BuildTypefield +Build.Downloadable()helper. Empty/unknownbuild_type⇒ allowed (legacy ADT drops must not wholesale-disable the picker); only an explicit non-buildinfotype is blocked.http.goparsesbuild_type.ADTBuild.build_type(field 6);adtBuildToProtomaps it. Stubs + swagger regenerated.adt-build-picker.tsx): per-buildbuild_typetag (green for buildinfo) + greys out / disables selection of non-buildinfo cards with a "only buildinfo builds can be distributed" note. List stays unfiltered (both types shown); ADT's server-side?buildType=filter deliberately not sent.cli.md,STATUS_M5.mdC15.Additive response field — no migration, no new RPC.
Verification
go test ./...✓golangci-lint run— 0 issues ✓npm run build✓make smokePASS ✓Out of scope (noted in STATUS C15)
Server-side
CreatePlaytest/ChangeADTBuildrejection of a non-buildinfoadt_build_id— today the UI prevents selection but the API would still accept one.🤖 Generated with Claude Code