feat: implement contributing guide - #5
Merged
tryajitiono-ab merged 10 commits intoFeb 10, 2026
Merged
Conversation
abdmmar
reviewed
Feb 10, 2026
abdmmar
reviewed
Feb 10, 2026
abdmmar
reviewed
Feb 10, 2026
rayhan-ab
reviewed
Feb 10, 2026
rayhan-ab
reviewed
Feb 10, 2026
|
|
||
| - When hiding modals, prefer using `open` prop as opposed to returning `null`. For example: | ||
|
|
||
| ```tsx |
There was a problem hiding this comment.
just curious, will this convention be applied to this repo only or we can apply it to our other repos? because i've seen a lot of modals in AP are like {isOpen && }
Contributor
Author
There was a problem hiding this comment.
I'm kinda hoping we can apply it to other repos because it seems awkward (from my perspective, anyway) if we already define open prop but we don't want to define open={isOpen}.
But I'd say it's case-by-case, if the component contains other components, I think return null is fine. But if it only contains the modal itself, I think we can just inline it with the prop.
Also, Ant Design docs seem to prefer that way, too: https://ant.design/components/modal#modal-demo-basic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of PR:
create-planandcontributeskills.Desktop screens
Mobile screens