Skip to content

feat: implement contributing guide - #5

Merged
tryajitiono-ab merged 10 commits into
AccelByte:mainfrom
tryajitiono-ab:test-implement-with-agent
Feb 10, 2026
Merged

tryajitiono-ab merged 10 commits into
AccelByte:mainfrom
tryajitiono-ab:test-implement-with-agent

Conversation

@tryajitiono-ab

Copy link
Copy Markdown
Contributor

Scope of PR:

  • Implement contributing guide
  • Implement foundation of AI-assisted development using create-plan and contribute skills.
  • Add missing dependencies, e.g. Prettier, so that the AI agent can reformat the files changed.

Desktop screens

image image

Mobile screens

image image

@tryajitiono-ab tryajitiono-ab self-assigned this Feb 10, 2026
Comment thread app/routes/home.tsx Outdated
Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
Comment thread app/components/ContributingGuideModal.tsx Outdated
Comment thread AGENTS.md

- When hiding modals, prefer using `open` prop as opposed to returning `null`. For example:

```tsx

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, will this convention be applied to this repo only or we can apply it to our other repos? because i've seen a lot of modals in AP are like {isOpen && }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda hoping we can apply it to other repos because it seems awkward (from my perspective, anyway) if we already define open prop but we don't want to define open={isOpen}.

But I'd say it's case-by-case, if the component contains other components, I think return null is fine. But if it only contains the modal itself, I think we can just inline it with the prop.

Also, Ant Design docs seem to prefer that way, too: https://ant.design/components/modal#modal-demo-basic

@tryajitiono-ab
tryajitiono-ab merged commit 002571a into AccelByte:main Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants