fix: refresh user token on public iam client - #16
Merged
Merged
Conversation
Public IAM clients (no secret) sent client_id in the refresh form body rather than via Basic auth, which the token endpoint rejected — breaking token refresh for authorization-code profiles. Always send Basic auth (client_id with an empty secret for public clients) and drop the form-body client_id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
For public IAM clients (no client secret), the refresh-token request sent
client_idin the form body instead of via HTTP Basic auth. The token endpoint rejected this, so token refresh failed for authorization-code (browser-login) profiles — users were forced to re-login once their access token expired.Fix
Always send Basic auth on refresh —
client_id:client_secretfor confidential clients,client_id:(empty secret) for public clients — and drop the form-bodyclient_id.Tests
client_idin the form body.