[feat] adds --bad-pixels-path - #315
Merged
antond-weta merged 1 commit intoAug 14, 2026
Merged
Conversation
Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 91.90% 91.91% +0.01%
==========================================
Files 17 17
Lines 3781 3787 +6
Branches 559 559
==========================================
+ Hits 3475 3481 +6
Misses 306 306
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
soswow
reviewed
Aug 14, 2026
| /// A path to the file containing a list of bad bixels in libraw format: | ||
| /// a plain text where each line describes a single bad pixel using | ||
| /// three numbers separated by whitespace for the column, row and UNIX | ||
| /// timestamp. |
Contributor
There was a problem hiding this comment.
what's unix timestamp is for? o_O
Contributor
Author
There was a problem hiding this comment.
to ignore the bad pixels which appeared after the image had been taken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds
--bad-pixels-pathparameter which provides a list of bad pixels to libraw.Tests
yes
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.