feat: Add lowercase usernames, reserved usernames, and federation tests - #459
Open
habdullhigh wants to merge 3 commits into
Open
feat: Add lowercase usernames, reserved usernames, and federation tests#459habdullhigh wants to merge 3 commits into
habdullhigh wants to merge 3 commits into
Conversation
|
Someone is attempting to deploy a commit to the Abdulazeem's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@habdullhigh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Owner
|
Fix backend build test error |
Owner
|
Resolve conflicts and fix backend build error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements user registration hardening and increases test coverage for the federation endpoint.
Issue References
/federationChanges Made
admin,root,stellar, etc.) that are prohibited during registration. The/registerendpoint now correctly returns a403 Forbiddenresponse when an attempt is made to claim one of these names..toLowerCase()) before being stored, and that all federation lookups are executed case-insensitively to prevent impersonation.federation.test.jsusing Jest and Supertest to fully exercise theGET /federation?q=...endpoint. Tests cover successful address lookups,type=idlookups, and missing/invalid username flows (404 Not Found). Also added tests toserver.test.jsto cover the new reserved usernames functionality.