ci: exit cleanly after the rawspeed-cli smoke test - #2
Merged
Merged
Conversation
The smoke test intentionally runs rawspeed-cli without arguments, and
the tool exits with code 2 after printing its usage. The GitHub
Actions runner appends `exit $LASTEXITCODE` to pwsh scripts, so the
step inherited that 2 and was marked failed even though the check
itself passed ("smoke test ok"). End the step with an explicit exit 0
on success; the throw on failure is unchanged.
AI assistance disclosure: prepared with AI assistance (opencode), per
AGENTS.md disclosure rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rawspeed-cli publishworkflow's smoke test step failed on therawspeed-cli-v1.0.1tag run even though the check itself passed("smoke test ok" was printed).
Root cause: the tool exits with code 2 after printing its usage,
and the GitHub Actions runner appends
exit $LASTEXITCODEto pwshscripts, so the step inherited that 2 and was marked failed.
Fix: end the smoke test step with an explicit
exit 0on success;the
throwon failure is unchanged.Verification
check passed, step exits 0.
(failed at "Smoke test" despite "smoke test ok")
Notes