Skip to content

fix(composables): 配置保存失败时不再提示已保存 - #1965

Merged
jinghero merged 1 commit into
AUTO-MAS-Project:devfrom
jinghero:fix/native-config-save-feedback
Nov 13, 2026
Merged

jinghero merged 1 commit into
AUTO-MAS-Project:devfrom
jinghero:fix/native-config-save-feedback

Conversation

@jinghero

Copy link
Copy Markdown
Contributor

摘要

  • 原生配置保存期间收到后端错误后,不再同时提示“已保存”。
  • 重新打开配置后清除上次的失败状态,正常保存仍会提示成功。

验证

  • Windows,提交 f3773f36e。新增回归在修复前失败、修复后通过,覆盖失败保存和下一次正常保存。
  • yarn test src/composables/useNativeGuiSession.test.ts src/composables/useTaskApi.test.ts src/composables/useTaskRuntimeState.test.ts:16 项通过。
  • yarn lint、yarn typecheck、yarn format:check 通过。lint 保留原有 QueueDeleteButton.text 告警。
  • HTTP、WebSocket 和提示边界已隔离,未运行真实原生配置窗口。统计沿用现有请求结果口径。

@github-actions github-actions Bot added 模块: 调度 按更新日志碎片自动设置 类型: 修复 按更新日志碎片自动设置 labels Nov 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T03:25:17.434628Z f3773f3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

总体结论:可以合并

AUTO-MAS-Project/AUTO-MAS #1965

这次不会再让“保存失败”和“已保存”抢着报信啦。dot酱核对了保存请求、任务错误通知和会话清理的顺序,审查范围内没有必须修改项。

失败标记留在当前会话里,停止请求和清理不会提前清掉它;保存等待结束前又不能开启新会话,所以既能拦住这次错误的成功提示,也不会把失败带到下一次配置。继续复用现有会话和订阅流程就够了,没有另添一套状态管理,这样挺合适喵。

新增回归覆盖了停止请求期间收到错误、下一轮正常保存恢复成功提示。dot酱读取的 CI 日志中,该文件 3 项测试通过,前端共 62 个测试文件、349 项测试通过;类型和格式检查通过,lint 仅有原有的 QueueDeleteButton.text 告警。本次是静态审查,未独立运行项目或真实原生配置窗口;现有 300ms 等待窗口也仍不是所有迟到消息的送达保证,不把这次修复说得比实际更大啦。

—— dot酱拍拍爪敬上 🐾

@jinghero
jinghero merged commit abb36a9 into AUTO-MAS-Project:dev Nov 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

模块: 调度 按更新日志碎片自动设置 类型: 修复 按更新日志碎片自动设置

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant