Repository navigation
fix(composables): 配置保存失败时不再提示已保存 - #1965
Merged
jinghero merged 1 commit intoNov 13, 2026
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
总体结论:可以合并AUTO-MAS-Project/AUTO-MAS #1965 这次不会再让“保存失败”和“已保存”抢着报信啦。dot酱核对了保存请求、任务错误通知和会话清理的顺序,审查范围内没有必须修改项。 失败标记留在当前会话里,停止请求和清理不会提前清掉它;保存等待结束前又不能开启新会话,所以既能拦住这次错误的成功提示,也不会把失败带到下一次配置。继续复用现有会话和订阅流程就够了,没有另添一套状态管理,这样挺合适喵。 新增回归覆盖了停止请求期间收到错误、下一轮正常保存恢复成功提示。dot酱读取的 CI 日志中,该文件 3 项测试通过,前端共 62 个测试文件、349 项测试通过;类型和格式检查通过,lint 仅有原有的 —— dot酱拍拍爪敬上 🐾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
验证
f3773f36e。新增回归在修复前失败、修复后通过,覆盖失败保存和下一次正常保存。yarn test src/composables/useNativeGuiSession.test.ts src/composables/useTaskApi.test.ts src/composables/useTaskRuntimeState.test.ts:16 项通过。yarn lint、yarn typecheck、yarn format:check通过。lint 保留原有QueueDeleteButton.text告警。