Repository navigation
fix(settings): 启动与窗口改为单列行式,依赖项按状态置灰 - #1946
Merged
Merged
Conversation
- 卡片改用 SettingRow 单列排版,删除自定义双列网格与 36px 行式 - 启动、关闭、托盘三组开关统一为 a-switch,关闭行为改用 a-segmented - 静默启动在自启与定时唤醒均关闭时禁用;再次关闭提示在非托盘模式时禁用 - 托盘菜单并入行式布局:预览降为说明,编辑入口移入控件列 - SettingRow 新增 child / disabled 两个可选 prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
证据
修复前已复现三个目标浏览器场景失败:旧 checkbox/布局定位失效,以及退出模式下关闭确认被禁用;修复后三个场景均已验证通过。
在
frontend/运行yarn lint、yarn typecheck、yarn format:check、yarn e2e:check均通过。Lint 保留已有的QueueDeleteButton.vue可选 prop 默认值警告。yarn test src/composables/useAppClosePreferences.test.ts src/i18n/locales.test.ts:2 个文件、3 个用例通过。yarn e2e --grep 'anchors question hints|saves scheduled wake-up|preserves close and appearance':提示定位及启动偏好通过;关闭行为通过后发现旧主题颜色断言漂移,按现有主题定义纠正后,yarn e2e --grep 'preserves close and appearance'单独复跑通过。E2E 使用隔离数据根,前端端口 5174、后端端口 36174;已检查浅色和深色截图。
uv run --locked python scripts/changelog.py check --pr-base origin/dev --pr-kind normal与git diff --check通过。Windows CI 曾在 OK-WW 更新测试中因父任务被垃圾回收而失败;
38f906d39将夹具改为yield并在现有参数化用例中主动触发 GC。修复前两个参数均复现同一错误,修复后uv run --locked --group dev python -m pytest tests/task/test_okww_game_update.py -q --tb=short --basetemp <独立临时目录> -p no:cacheprovider全部 11 项通过;uv run --locked ruff format --check tests/task/test_okww_game_update.py通过。本机默认 pytest 临时目录存在权限问题,验证使用独立临时目录。最新提交
38f906d39的 CI 检查已全部通过,含格式检查、Windows 验证包构建及 Python 全量测试:Windows 2023 项通过、1 项跳过;Ubuntu 1980 项通过、43 项跳过;两端均有 17 个子测试通过。合并风险
影响范围为启动与窗口卡片、托盘菜单及
SettingRow的可选子项/禁用样式。关闭偏好继续使用现有保存及统计入口;静默启动保留原有运行语义。已验证浏览器交互,未验证真实 Electron 启动、操作系统自启和定时唤醒。