Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e03c5a4bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| init.resetDesktopStartup() | ||
| } | ||
| const version = resolveRuntimeTargetVersion() | ||
| const result = await startDesktopStartup({ |
There was a problem hiding this comment.
Mark update-dialog restarts as explicit startup retries
When the post-update “Restart backend” action fails, useBackendRuntimeUpdate.restartBackend() continues calling backendStart() without the retry flag (frontend/src/composables/useBackendRuntimeUpdate.ts:207). Routing those calls through startDesktopStartup() now preserves that failed attempt in desktopStartup, so subsequent button presses return the cached failure at the guard above instead of creating another Runtime process—even after the underlying error clears. Previously these calls reached backend.startBackend() on each press. Pass explicit retry intent from this recovery action while retaining cached results for ordinary requests attaching to the startup task.
Useful? React with 👍 / 👎.
已由 PR #1938 替代。新 PR 和提交说明已改成直白的说法,文件内容逐个核对一致。