fix(unity-bootstrap-theme): fix anchor menu js#1667
Open
davidornelas11 wants to merge 2 commits intodevfrom
Open
fix(unity-bootstrap-theme): fix anchor menu js#1667davidornelas11 wants to merge 2 commits intodevfrom
davidornelas11 wants to merge 2 commits intodevfrom
Conversation
davidornelas11
force-pushed
the
anchor-menu-issue
branch
from
b220a3a to
3feae2e
Compare
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1667/index.html |
mlsamuelson
requested changes
Apr 2, 2026
Member
mlsamuelson
left a comment
mlsamuelson
left a comment
There was a problem hiding this comment.
Are there limitations on how should I be able to verify this one in storybook? I haven't dug into the stories and how their assets are loaded in storybook since they're not in the PR, but what I see is:
- asu-react-core react anchor works
- asu-react-core bootstrap anchor doesn't
- unity-bootstrap-theme anchor works
Given that the pr is for unity-bootstrap-theme, I thinking this is a pass, but wondering if there's any way the asu-react-core fix can happen, or is does that involve the future breaking change?
| const topOffset = headerBottom + navbarHeight; | ||
| const targetTop = anchorTarget.getBoundingClientRect().top; | ||
| const viewportMid = window.innerHeight / 2; | ||
| console.log("viewportmid", viewportMid, "targetTop", targetTop); |
Member
There was a problem hiding this comment.
Can we remove this console.log?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchor menu fix to fix the focus order as well as adds correct hash in url bar. Also adds check for unity-react-core react anchor menu since that handles its own logic, currently used in app degree detail page. Eventually we want to remove that logic in the unity-react-core anchor menu but that will be a breaking change.
Description
Checklist
Important Reminders
Links