feat(unity-bootstrap-theme): added new header styles and stories#1657
Open
davidornelas11 wants to merge 2 commits intodevfrom
Open
feat(unity-bootstrap-theme): added new header styles and stories#1657davidornelas11 wants to merge 2 commits intodevfrom
davidornelas11 wants to merge 2 commits intodevfrom
Conversation
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1657/index.html |
| <img | ||
| src={menuSearchIcon} | ||
| alt="Menu and Search Icon" | ||
| className="menu-search-icon" |
Contributor
There was a problem hiding this comment.
Hey @davidornelas11
Should not we use FAwesome search icon?
I mean menu-search-icon.png is a raster image for a UI icon to avoid using images.
Just asking.
Contributor
Author
There was a problem hiding this comment.
I didnt see the fontawesome search icon that brand wanted. They want to sue this specific one
| #asu-header.uds-header-v2 { | ||
| // --- Top bar: search button/input/submit --- | ||
| #wrapper-header-top { | ||
| padding: 0.5rem 0rem; |
Contributor
There was a problem hiding this comment.
Can we uses variables instead ?
$uds-size-spacing-1 $uds-size-spacing-0
| } | ||
| #header-top { | ||
| .nav > *:not(:last-child) { | ||
| margin-right: 1.5rem; |
Contributor
There was a problem hiding this comment.
Same here : margin-right: 1.5rem │ $uds-size-spacing-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added new header styles and stories in unity-bootstrap-theme
Description
Checklist
Important Reminders
Links