Skip to content

feat(component-header-footer): add multi column dropdown, limit mega menu width#1631

Closed
scott-williams-az wants to merge 11 commits intodevfrom
uds-1875c
Closed

feat(component-header-footer): add multi column dropdown, limit mega menu width#1631
scott-williams-az wants to merge 11 commits intodevfrom
uds-1875c

Conversation

@scott-williams-az
Copy link
Copy Markdown
Contributor

@scott-williams-az scott-williams-az commented Feb 18, 2026

Description

Checklist

  • Tests pass for relevant code changes

Important Reminders

Links

@scott-williams-az scott-williams-az requested a review from a team as a code owner February 18, 2026 19:17
@asu-jenkins-devops
Copy link
Copy Markdown
Collaborator

@davidornelas11
Copy link
Copy Markdown
Contributor

I did notice that when a dropdown menu is opened, since the scroll behavior is removed from the main page there is a page shift from the toolbar being remvoed

@davidornelas11
Copy link
Copy Markdown
Contributor

Just some linting conflicts I believe @scott-williams-az

Copy link
Copy Markdown
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scott-williams-az Conflicts to resolve.

Also, saw the scrollbar jump result in shifts as well.

@mlsamuelson
Copy link
Copy Markdown
Member

How to see the shift... go to https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1631/@asu/component-header-footer/index.html?path=/story/uds-asu-header--default and ensure there's a scrollbar on the right side of the screen. Open a dropdown that has a scrollbar, and the edge of the page scrollbar will be removed while that dropdown is open and the page layout will shift.

@scott-williams-az
Copy link
Copy Markdown
Contributor Author

As for the page shift. I learned a new trick

html {
  scrollbar-gutter: stable;
}

@mlsamuelson
Copy link
Copy Markdown
Member

@scott-williams-az Got a review from the GTM team testing the data layer:

Hi,

Thank you for including me in your biweekly meeting that we had today! I had a chance to review the updated make to the nav bar and the data layer and everything looks great expect for the component section of the data layer.

On my end, I am not seeing any text populating that field currently and after reviewing Jonthan, we want to make sure that all fields are being populated properly before publishing any changes.

I hope this is not a difficult thing to address.
image

Thank you again!

Best,
Abigail Abdiyeva
Marketing Analyst Specialist
Data analytics and insights
ASU Enterprise Partners

@scott-williams-az
Copy link
Copy Markdown
Contributor Author

Continued with PR #1672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants