Add functional modules for VOICEBOX update - #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| except Exception as exc: # noqa: BLE001 | ||
| logger.exception("Ошибка транскрибации") | ||
| self._append_log(f"Ошибка: {exc}") | ||
| messagebox.showerror("Ошибка", str(exc)) | ||
| finally: | ||
| if temp_holder: | ||
| temp_holder.close() |
There was a problem hiding this comment.
In _transcribe_selected the cleanup at finally: uses temp_holder even though this variable is only assigned later in the try body; if ensure_file_exists or WhisperTranscriber fails before the assignment (e.g., when a user selects a missing file), temp_holder is undefined and the finally block raises UnboundLocalError, masking the original problem and breaking the error dialog. Initialize temp_holder before entering the try or guard the reference so early failures don’t crash the GUI.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
Codex Task