Repository navigation
Use safe-struct chain info copy - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we refactored the code to use safe-struct to avoid const-casting in layer code we failed to change the chain info pointer, so kept modifying the original user chain info rather than modifying the the safe-struct clone. This passed all our tests because when you are using a single layer you talk directly to the driver, which doesn't use the chain info, but it fails as soon as you have multiple layers because the chain is never advanced as you call down the stack. The end result is an infinite recursion of vkCreateInstance/vkCreateDevice calls into the second layer in the stack of N layers.
Fixes #157