Conversation
…olor, window corners (bevels and rounds), Glow colors and more
…o PAM The netwatch SDDM theme's login form only had a password input; doAuth() called sddm.login(userModel.lastUser, ...) to supply the username. On at least one setup userModel.lastUser resolves empty, so SDDM sends an empty username string to PAM regardless of the password typed — confirmed via journalctl -u sddm showing `Authentication for user "" failed`. Adds a real username TextInput bound to a new lockUser property (seeded from userModel.lastUser as a convenience default, but user-editable). doAuth() now sends lockUser and won't fire until both fields are non-empty. Focus starts on the username field when empty, else the password field; Tab/Shift+Tab move between the two fields. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0164AbQ8QodPJqEANRYzGxVa
…-username fix(sddm/netwatch): stop sending empty username to PAM
…hyprbars and sum minor tweaks
tiredbooy
changed the title
ARCANGEL0
force-pushed
the
master
branch
10 times, most recently
from
September 14, 2026 16:56
fa4af8a to
1d28ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.sh --dry-runexit before prompts or privileged mutations/etc/sddm.conf.pre-cyberarchProblem
The Netwatch SDDM theme currently passes
sessionModel.lastIndextosddm.login()without exposing a way to choose another installed desktop session. On systems with CyberArch/Hyprland installed alongside KDE Plasma or another desktop, this can repeatedly launch the previously selected session.The installer also advertised a no-change dry run after already reaching its system-upgrade prompt and
sudo pacman -Sy. Its SDDM setup selected the theme before confirming that deployment succeeded, and failed display-manager activation paths did not consistently restore the previous manager.Safety
The dry run now performs only local dependency queries. SDDM activation is ordered after theme deployment and configuration backup, and each activation/start failure uses the same rollback path. No system-wide installation was performed while developing this change.
Testing
QT_QPA_PLATFORM=offscreen /usr/lib/qt6/bin/qmltestrunner -input tests/qml -o -,txt— 7 passedqmllinton the Netwatch QML components — passedbash tests/install/test_install_safety.sh— passedTERM=dumb ./install.sh --dry-run— passed without sudo or promptsbash -n install.sh updater.sh tests/install/test_install_safety.sh— passedshellcheck --severity=error -e SC1087 install.sh tests/install/test_install_safety.sh— passedgit diff --check— passedsddm-greeter-qt6 --test-mode --theme components/login/sddm-theme— no QML errors