Skip to content

feat: robust app launching, aurbar toggle, float→int rounding - #19

Open
yorokobiyokai wants to merge 1 commit into
ARCANGEL0:masterfrom
yorokobiyokai:master
Open

yorokobiyokai wants to merge 1 commit into
ARCANGEL0:masterfrom
yorokobiyokai:master

Conversation

@yorokobiyokai

Copy link
Copy Markdown

Summary

appsmenu.ts — Robust app activation & click fix

  • Session environment: ensureSessionEnv() sets XDG_RUNTIME_DIR, DBUS_SESSION_BUS_ADDRESS, XDG_SESSION_TYPE, XDG_CURRENT_DESKTOP, XDG_SESSION_DESKTOP, DISPLAY before every launch.
  • New launchAppRobust(): tries the cyberarch-launch-desktop helper script first; falls back to Gio.AppLaunchContext for desktop-file IDs. Adds debug prints for traceability.
  • Click Y-coordinate: reads coordinates directly from button-press-event via e.get_coords() instead of relying on a stale motion-notify cache. Falls back to closest rendered row when the click lands between items.

theme.lua — Float precision fix & startup cleanup

  • Cast border_size, glow_range, glow_rp, rounding, shadow_range to integers via math.floor(x + 0.5) for cleaner wibox painting.
  • Removed waybar from the AGS startup kill-list (no longer managed here). Added a guard so launch-theme only runs if cyberpunk isn't already running (ags list | grep -qx cyberpunk).

core.ts — Conditional AurBar

  • New toggle file ~/.config/cyberarch/disable-aurbar. If present, the aurora bar is skipped at startup.

Checklist

  • Tested app launch from wheel on Hyprland/XDG session

appsmenu:
- ensure SessionEnv before every launch (XDG_RUNTIME_DIR, DBUS,
  XDG_SESSION_TYPE, DISPLAY)
- new launchAppRobust(): try cyberarch-launch-desktop helper first,
  fallback to Gio.AppLaunchContext for desktop file IDs
- fix click-y in button-press by reading e.get_coords() directly
  instead of relying on stale motion-notify cache; add nearest-row
  fallback and debug prints

core:
- conditional AurBar via disable-aurbar toggle file

theme.lua:
- cast border_size, glow_range, glow_rp, rounding, shadow_range to
  integers with floor(x+0.5) for cleaner wibox painting
- drop waybar from AGS startup kill list (no longer managed here);
  only relaunch cyberpunk if not already running
@ARCANGEL0

Copy link
Copy Markdown
Owner

Thanks for the contribution :)

I've been postponing to address the mishandling issues with X11 env variables that were giving errors on X display apps for some users, but didn't had time lately.

One question, where is this cyberarch launch desktop being called from? it's not native from the theme... so it would give out an issue on that LAUNCHER_HELPER on the menu component. and this would be an runtime catch at the execAsync there.. i only see it being assigned on appsmenu:319.

@ARCANGEL0
ARCANGEL0 force-pushed the master branch 10 times, most recently from fa4af8a to 1d28ca6 Compare September 14, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants