feat: robust app launching, aurbar toggle, float→int rounding - #19
Open
yorokobiyokai wants to merge 1 commit into
Open
yorokobiyokai wants to merge 1 commit into
yorokobiyokai wants to merge 1 commit into
Conversation
appsmenu: - ensure SessionEnv before every launch (XDG_RUNTIME_DIR, DBUS, XDG_SESSION_TYPE, DISPLAY) - new launchAppRobust(): try cyberarch-launch-desktop helper first, fallback to Gio.AppLaunchContext for desktop file IDs - fix click-y in button-press by reading e.get_coords() directly instead of relying on stale motion-notify cache; add nearest-row fallback and debug prints core: - conditional AurBar via disable-aurbar toggle file theme.lua: - cast border_size, glow_range, glow_rp, rounding, shadow_range to integers with floor(x+0.5) for cleaner wibox painting - drop waybar from AGS startup kill list (no longer managed here); only relaunch cyberpunk if not already running
Owner
Thanks for the contribution :)I've been postponing to address the mishandling issues with X11 env variables that were giving errors on X display apps for some users, but didn't had time lately. One question, where is this cyberarch launch desktop being called from? it's not native from the theme... so it would give out an issue on that LAUNCHER_HELPER on the menu component. and this would be an runtime catch at the execAsync there.. i only see it being assigned on appsmenu:319. |
ARCANGEL0
force-pushed
the
master
branch
10 times, most recently
from
September 14, 2026 16:56
fa4af8a to
1d28ca6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appsmenu.ts— Robust app activation & click fixensureSessionEnv()sets XDG_RUNTIME_DIR, DBUS_SESSION_BUS_ADDRESS, XDG_SESSION_TYPE, XDG_CURRENT_DESKTOP, XDG_SESSION_DESKTOP, DISPLAY before every launch.launchAppRobust(): tries thecyberarch-launch-desktophelper script first; falls back toGio.AppLaunchContextfor desktop-file IDs. Adds debug prints for traceability.button-press-eventviae.get_coords()instead of relying on a stale motion-notify cache. Falls back to closest rendered row when the click lands between items.theme.lua— Float precision fix & startup cleanupborder_size,glow_range,glow_rp,rounding,shadow_rangeto integers viamath.floor(x + 0.5)for cleaner wibox painting.launch-themeonly runs if cyberpunk isn't already running (ags list | grep -qx cyberpunk).core.ts— Conditional AurBar~/.config/cyberarch/disable-aurbar. If present, the aurora bar is skipped at startup.Checklist