Skip to content

Explain empty staff pet dropdowns and return after adding a pet - #210

Open
apescic-director wants to merge 2 commits into
mainfrom
bmurphy/fix-143-empty-pet-dropdown-7748
Open

apescic-director wants to merge 2 commits into
mainfrom
bmurphy/fix-143-empty-pet-dropdown-7748

Conversation

@apescic-director

@apescic-director apescic-director commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #143

Staff Shelter case and Pet Care consultation create forms that need a pet showed a blank dropdown with no explanation and no way to add a pet first.

What this changes

  • When staff have no visible pet profiles, the create panel shows an empty state instead of a blank select
  • Staff who can create pets get an Add a pet first link to Shelter /shelter/pets#create or Pet Care /petcare/pets#create
  • After saving that pet, staff return to the original create form with the new pet selected
  • Public own-record empty dropdowns are unchanged (parked on [Task] Create a live public local test account #129)
  • Unsafe return_to values are ignored so pet create still lands on the new pet page

Out of scope

Tests

  • StaffEmptyPetSelectTest covers empty-state copy and add-pet return on Shelter cases and Pet Care consultations, public users keeping a blank select, staff with pets keeping the dropdown, staff without pet-create permission seeing the explanation without the link, and rejected external return URLs
  • StaffPetCreateReturnTest covers the allowed return keys
  • Version-pinned changelog, health, and rollback contract tests updated for v0.33.1
  • php artisan myapes:changelog-validate --base-ref=origin/main passed on the PR branch
  • Focused PHPUnit (StaffEmptyPetSelectTest, StaffPetCreateReturnTest, ShelterCaseWorkflowTest, PetCareConsultationWorkflowTest, ShelterPetProfileWorkflowTest, PetCarePetProfileWorkflowTest, ServiceHubQuickLinksTest, ReleaseHistoryCommandTest, ChangeLogPageTest, HealthAndThemeTest, ModuleRollbackCompatibilityTest) passed

composer pre-pr-verify was not run as the Composer script (PowerShell). Changelog-validate and the focused PHPUnit set above were run on Linux instead. A live browser preview was not started in this environment; verification is route- and test-based.

Release metadata

This PR includes v0.33.1 (VERSION, resources/data/releases.json, resources/data/module-runtime-contract.json).

Open in Web Open in Cursor 

cursoragent and others added 2 commits September 14, 2026 10:49
Shelter case and Pet Care consultation create forms left staff with a blank pet select and no path to add a profile first. Show an empty state with an add-pet link, then send staff back to the original form with the new pet selected.

Co-authored-by: APES Director <apescic-director@users.noreply.github.com>
Co-authored-by: APES Director <apescic-director@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T10:55:55.042082Z 092f133 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v1.2.0] 02 [Bug] Create forms that need a pet have an empty dropdown and no add-pet link

2 participants