Explain empty staff pet dropdowns and return after adding a pet - #210
Open
apescic-director wants to merge 2 commits into
Open
apescic-director wants to merge 2 commits into
apescic-director wants to merge 2 commits into
Conversation
Shelter case and Pet Care consultation create forms left staff with a blank pet select and no path to add a profile first. Show an empty state with an add-pet link, then send staff back to the original form with the new pet selected. Co-authored-by: APES Director <apescic-director@users.noreply.github.com>
Co-authored-by: APES Director <apescic-director@users.noreply.github.com>
apescic-director
marked this pull request as ready for review
September 14, 2026 10:51
3 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143
Staff Shelter case and Pet Care consultation create forms that need a pet showed a blank dropdown with no explanation and no way to add a pet first.
What this changes
/shelter/pets#createor Pet Care/petcare/pets#createreturn_tovalues are ignored so pet create still lands on the new pet pageOut of scope
Tests
StaffEmptyPetSelectTestcovers empty-state copy and add-pet return on Shelter cases and Pet Care consultations, public users keeping a blank select, staff with pets keeping the dropdown, staff without pet-create permission seeing the explanation without the link, and rejected external return URLsStaffPetCreateReturnTestcovers the allowed return keysphp artisan myapes:changelog-validate --base-ref=origin/mainpassed on the PR branchStaffEmptyPetSelectTest,StaffPetCreateReturnTest,ShelterCaseWorkflowTest,PetCareConsultationWorkflowTest,ShelterPetProfileWorkflowTest,PetCarePetProfileWorkflowTest,ServiceHubQuickLinksTest,ReleaseHistoryCommandTest,ChangeLogPageTest,HealthAndThemeTest,ModuleRollbackCompatibilityTest) passedcomposer pre-pr-verifywas not run as the Composer script (PowerShell). Changelog-validate and the focused PHPUnit set above were run on Linux instead. A live browser preview was not started in this environment; verification is route- and test-based.Release metadata
This PR includes v0.33.1 (
VERSION,resources/data/releases.json,resources/data/module-runtime-contract.json).