Feature/upgrade formio react 2.0.0#2
Open
Josephalexantony-aot wants to merge 112 commits into
Open
Conversation
This CONTRIBUTING.md file will help our fellow contributors to show by which mens they can contribute to this project
* Rewrites of the major components (Form, FormBuilder, FormGrid, SubmissionGrid, etc.) to idiomatic React and Typescript * Tooling updates (eslint, typescript, no more babel, etc.) * Many more...
…erences into event handlers
FIO-7733: React Updates
Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.91.0...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.17.0 to 8.18.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.0...8.18.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ces-3.0.3 Bump braces from 3.0.2 to 3.0.3
…8.18.0 Bump ws from 8.17.0 to 8.18.0
FIO-9944: Fixes an issue where some form instances will not be destroyed
…tion notices to ReactComponent'
…ct formBuilder logic'
…ssue where form tags are not displayed in Form Edit'
…edit conflict resolution'
… form sync issues'
…ory leak where create form promise fullfills only after original component got unmount'
…e state bugs in efb demo'
…ssue where react form builder does not work correctly after react component redraw'
- Rename package to @aot-technologies/formio-react, version 2.0.0 - Swap all @formio/js imports to @aot-technologies/formiojs - Port iterateConditionsAndSetLogic + createCustomConditions from develop into FormBuilder.tsx so conditional chain logic is preserved - Add @aot-technologies/formiojs as peer dependency Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Resolution strategy: - Old .jsx files (Form, FormBuilder, FormEdit, SubmissionGrid): deleted — superseded by TypeScript .tsx rewrites from upstream 6.1.0 - babel.config.json: deleted — new build uses tsc, not Babel - package.json, imports, README: kept our branch version which carries all AOT customizations (@aot-technologies/formiojs, v2.0.0, package rename) - webpack.test.config.js: auto-merged from develop (legacy, unused by Jest) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… swap - Add @formio/js to devDependencies so its type declarations are available at build time (runtime uses @aot-technologies/formiojs, types come from the upstream @formio/js package which it is a fork of) - Add src/aot-formiojs.d.ts shim so tsc resolves @aot-technologies/formiojs and /utils and /lib subpaths to @formio/js type declarations - Add explicit WebformInstance | null and FormioFormBuilder | null type annotations on two prevInstance parameters flagged by strict mode (TS7006) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-XXXX
Description
This PR brings the full upstream
@formio/react6.1.0 rewrite into ourdevelopbranch while preserving all AOT-specific customisations. No AOT code is lost.What's new from upstream
The upstream library underwent a major rewrite between the version
developwas based on and 6.1.0:.jsx→.tsxwith full type safetytscAOT-specific changes preserved
@aot-technologies/formio-react2.0.0@formio/jsreferences replaced with@aot-technologies/formiojsacross all source files@aot-technologies/formiojs ^1.0.2added topeerDependenciesiterateConditionsAndSetLogicandcreateCustomConditions(originally inFormBuilder.jsx) ported into the newFormBuilder.tsx— fires on everyonChangeevent to convert GUI-built conditional rules intocustomConditionalexpressionsFiles removed
These old
.jsxfiles were removed because they are fully superseded by the upstream.tsxrewrites:src/components/Form.jsx→ replaced byForm.tsxsrc/components/FormBuilder.jsx→ replaced byFormBuilder.tsxsrc/components/FormEdit.jsx→ replaced byFormEdit.tsxsrc/components/SubmissionGrid.jsx→ replaced bySubmissionGrid.tsxbabel.config.json→ no longer needed, build now usestscWhat changed?
Use this section to provide a summary description of the changes you've made
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
Use this section to list any dependent changes/PRs in other Form.io modules
How has this PR been tested?
Use this section to describe how you tested your changes; if you haven't included automated tests, justify your reasoning
Checklist: