Skip to content

test(simple): add direct unit tests for next_target and excluded (Fixes #257) #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoari merged 2 commits into from
Oct 31, 2026
Merged

test(simple): add direct unit tests for next_target and excluded (Fixes #257) #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1c1f1c
test(simple): add direct unit tests for next_target and excluded (Fix…
agarwalpranav0711 Oct 28, 2026
69cdb8a
Merge branch 'main' into test/next-target-unit-tests
ryoari Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions tests/simple/test_ovl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,5 +230,57 @@ def test_unknown_or_modified_weights_fail(self):
self.assertIsNone(report["checks"][0]["chain_entry"])


class NextTargetAndExclusionTests(unittest.TestCase):
def test_excluded_sorts_and_filters_by_phase(self):
ctl = {"phase": "wikipedia", "exclude": {"wikipedia": [[50, 10], [10, 5]], "conversation": [[5, 2]]}}
self.assertEqual(ovl.excluded(ctl), [(10, 5), (50, 10)])

ctl_conv = {"phase": "conversation", "exclude": {"wikipedia": [[10, 5]]}}
self.assertEqual(ovl.excluded(ctl_conv), [])

self.assertEqual(ovl.excluded({"phase": "wikipedia"}), [])

def test_next_target_empty_ranges(self):
self.assertEqual(ovl.next_target(10, []), 10)

def test_next_target_cursor_before_and_after_range(self):
ranges = [(10, 5)]
self.assertEqual(ovl.next_target(5, ranges), 5)
self.assertEqual(ovl.next_target(9, ranges), 9)
self.assertEqual(ovl.next_target(15, ranges), 15)
self.assertEqual(ovl.next_target(20, ranges), 20)

def test_next_target_cursor_inside_range(self):
ranges = [(10, 5)]
self.assertEqual(ovl.next_target(11, ranges), 15)
self.assertEqual(ovl.next_target(14, ranges), 15)

def test_next_target_boundaries_exact_s_and_exact_end(self):
ranges = [(10, 5)]
self.assertEqual(ovl.next_target(10, ranges), 15)
self.assertEqual(ovl.next_target(15, ranges), 15)

def test_next_target_back_to_back_contiguous_ranges(self):
ranges = [(10, 5), (15, 7)]
self.assertEqual(ovl.next_target(10, ranges), 22)
self.assertEqual(ovl.next_target(12, ranges), 22)
self.assertEqual(ovl.next_target(15, ranges), 22)
self.assertEqual(ovl.next_target(22, ranges), 22)

def test_next_target_multiple_spaced_ranges(self):
ranges = [(10, 5), (30, 10)]
self.assertEqual(ovl.next_target(10, ranges), 15)
self.assertEqual(ovl.next_target(12, ranges), 15)
self.assertEqual(ovl.next_target(20, ranges), 20)
self.assertEqual(ovl.next_target(30, ranges), 40)
self.assertEqual(ovl.next_target(35, ranges), 40)
self.assertEqual(ovl.next_target(40, ranges), 40)

def test_next_target_overlapping_ranges(self):
ranges = [(10, 8), (14, 6)]
self.assertEqual(ovl.next_target(10, ranges), 20)
self.assertEqual(ovl.next_target(15, ranges), 20)


if __name__ == "__main__":
unittest.main()
Loading