Skip to content

Implement same dependency/release update workflow as WarpX - #474

Merged
ax3l merged 3 commits into
AMReX-Codes:developmentfrom
EZoni:update_dependencies
Sep 17, 2025
Merged

Implement same dependency/release update workflow as WarpX#474
ax3l merged 3 commits into
AMReX-Codes:developmentfrom
EZoni:update_dependencies

Conversation

@EZoni

@EZoni EZoni commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Requested by @ax3l on Slack (to be used in #378):

Do you mind adding the Tools/Release/update_dependencies.py script (simply in /) to pyAMReX, too? Do not need the other automations for now.

WarpX references:

To-do:

  • AMReX
  • pybind11

@EZoni EZoni mentioned this pull request Sep 9, 2025
Merged
@EZoni
EZoni force-pushed the update_dependencies branch from 1aa978a to ad8b14e Compare September 9, 2025 21:19
@ax3l
ax3l self-requested a review September 10, 2025 21:41
@EZoni
EZoni force-pushed the update_dependencies branch from ad8b14e to db23d6e Compare September 10, 2025 22:31
EZoni
EZoni commented Sep 10, 2025
View reviewed changes
Comment thread update_dependencies.py

@EZoni EZoni Sep 10, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Down the road it would be nice if we found a way to make this a BLAST-level module, since a lot of code is shared with the WarpX script.

@EZoni EZoni changed the title [WIP] Implement same dependency/release update workflow as WarpX Implement same dependency/release update workflow as WarpX Sep 10, 2025
ax3l pushed a commit to BLAST-WarpX/warpx that referenced this pull request Sep 16, 2025
@EZoni
Fix minor bugs in script to update dependencies (#6150)
13dc6a9 
Fix a minor bug that I found while testing the same tool in
AMReX-Codes/pyamrex#474.
ax3l
ax3l requested changes Sep 16, 2025
View reviewed changes

@ax3l ax3l left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include dependencies.json in MANIFEST.in, otherwise PyPI source packages (uncompiled) will lack the file and CMake builds from pip source packages will fail.

@ax3l

ax3l commented Sep 16, 2025

Copy link
Copy Markdown
Member

I'll add it and post a fix to WarpX, too

@ax3l ax3l mentioned this pull request Sep 16, 2025
Open
2 tasks
ax3l
ax3l approved these changes Sep 16, 2025
View reviewed changes

@ax3l ax3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@ax3l
ax3l enabled auto-merge (squash) September 16, 2025 23:14
@ax3l
ax3l merged commit a1d7a94 into AMReX-Codes:development Sep 17, 2025
18 checks passed
@EZoni
EZoni deleted the update_dependencies branch November 25, 2025 23:04
@EZoni EZoni mentioned this pull request Nov 26, 2025
Merged
ax3l pushed a commit that referenced this pull request Nov 26, 2025
@EZoni
Always use version tag in pybind11 dependency update (#517)
c7c6e45 
Always use the version tag for pybind11 as we don't want to track
updates on a weekly basis.

Related PRs:
- #474
- #486

@ax3l Does this fix the issue that we discussed offline?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels

automation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EZoni @ax3l